Commit 271da132 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: phy: phy_led_triggers: Fix a possible null-pointer dereference in...

net: phy: phy_led_triggers: Fix a possible null-pointer dereference in phy_led_trigger_change_speed()

In phy_led_trigger_change_speed(), there is an if statement on line 48
to check whether phy->last_triggered is NULL:
    if (!phy->last_triggered)

When phy->last_triggered is NULL, it is used on line 52:
    led_trigger_event(&phy->last_triggered->trigger, LED_OFF);

Thus, a possible null-pointer dereference may occur.

To fix this bug, led_trigger_event(&phy->last_triggered->trigger,
LED_OFF) is called when phy->last_triggered is not NULL.

This bug is found by a static analysis tool STCheck written by
the OSLAB group in Tsinghua University.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e29903c4
...@@ -48,8 +48,9 @@ void phy_led_trigger_change_speed(struct phy_device *phy) ...@@ -48,8 +48,9 @@ void phy_led_trigger_change_speed(struct phy_device *phy)
if (!phy->last_triggered) if (!phy->last_triggered)
led_trigger_event(&phy->led_link_trigger->trigger, led_trigger_event(&phy->led_link_trigger->trigger,
LED_FULL); LED_FULL);
else
led_trigger_event(&phy->last_triggered->trigger, LED_OFF); led_trigger_event(&phy->last_triggered->trigger, LED_OFF);
led_trigger_event(&plt->trigger, LED_FULL); led_trigger_event(&plt->trigger, LED_FULL);
phy->last_triggered = plt; phy->last_triggered = plt;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment