Commit 2843cbb5 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Greg Kroah-Hartman

tty: serial: qcom_geni_serial: Drop useless check for dev.of_node

With gcc 4.1.2:

    drivers/tty/serial/qcom_geni_serial.c: In function ‘qcom_geni_serial_probe’:
    drivers/tty/serial/qcom_geni_serial.c:1261: warning: ‘drv’ may be used uninitialized in this function

Indeed, if dev.of_node is NULL, drv will be used uninitialized, and
dereferenced in uart_add_one_port().  However, as this driver supports
DT only, dev.of_node will always be valid.

Hence remove the useless check for dev.of_node, killing the warning as a
side effect.

Fixes: 8a8a66a1 ("tty: serial: qcom_geni_serial: Add support for flow control")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5963e8a3
...@@ -1263,14 +1263,12 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) ...@@ -1263,14 +1263,12 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
if (of_device_is_compatible(pdev->dev.of_node, "qcom,geni-debug-uart")) if (of_device_is_compatible(pdev->dev.of_node, "qcom,geni-debug-uart"))
console = true; console = true;
if (pdev->dev.of_node) { if (console) {
if (console) { drv = &qcom_geni_console_driver;
drv = &qcom_geni_console_driver; line = of_alias_get_id(pdev->dev.of_node, "serial");
line = of_alias_get_id(pdev->dev.of_node, "serial"); } else {
} else { drv = &qcom_geni_uart_driver;
drv = &qcom_geni_uart_driver; line = of_alias_get_id(pdev->dev.of_node, "hsuart");
line = of_alias_get_id(pdev->dev.of_node, "hsuart");
}
} }
port = get_port_from_line(line, console); port = get_port_from_line(line, console);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment