Commit 29e20aa6 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by John W. Linville

at76c50x-usb: fix use after free on failure path in at76_probe()

After commit 174beab7 ("at76c50x-usb: Don't perform DMA from stack memory")
at76_delete_device() and usb_put_dev() are called both
if at76_init_new_device() fails in at76_probe().
But at76_delete_device() does usb_put_dev(priv->dev) itself
that means double usb_put_dev().

The patch avoids the problem by moving usb_put_dev() from
at76_delete_device() to at76_disconnect().

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent e5cd6cee
...@@ -2423,8 +2423,6 @@ static void at76_delete_device(struct at76_priv *priv) ...@@ -2423,8 +2423,6 @@ static void at76_delete_device(struct at76_priv *priv)
kfree_skb(priv->rx_skb); kfree_skb(priv->rx_skb);
usb_put_dev(priv->udev);
at76_dbg(DBG_PROC_ENTRY, "%s: before freeing priv/ieee80211_hw", at76_dbg(DBG_PROC_ENTRY, "%s: before freeing priv/ieee80211_hw",
__func__); __func__);
ieee80211_free_hw(priv->hw); ieee80211_free_hw(priv->hw);
...@@ -2558,6 +2556,7 @@ static void at76_disconnect(struct usb_interface *interface) ...@@ -2558,6 +2556,7 @@ static void at76_disconnect(struct usb_interface *interface)
wiphy_info(priv->hw->wiphy, "disconnecting\n"); wiphy_info(priv->hw->wiphy, "disconnecting\n");
at76_delete_device(priv); at76_delete_device(priv);
usb_put_dev(priv->udev);
dev_info(&interface->dev, "disconnected\n"); dev_info(&interface->dev, "disconnected\n");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment