Commit 2ac21c6b authored by James Hogan's avatar James Hogan Committed by Rafael J. Wysocki

PM: Lock PM device list mutex in show_dev_hash()

Lock the PM device list mutex using device_pm_lock() and
device_pm_unlock() around the list iteration in show_dev_hash().

show_dev_hash() was reverse iterating dpm_list without first locking the
mutex that the functions in drivers/base/power/main.c lock. I assume
this was unintentional since there is no comment suggesting why the lock
might not be necessary.
Signed-off-by: default avatarJames Hogan <james@albanarts.com>
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
parent f71648d7
...@@ -188,8 +188,10 @@ static int show_file_hash(unsigned int value) ...@@ -188,8 +188,10 @@ static int show_file_hash(unsigned int value)
static int show_dev_hash(unsigned int value) static int show_dev_hash(unsigned int value)
{ {
int match = 0; int match = 0;
struct list_head *entry = dpm_list.prev; struct list_head *entry;
device_pm_lock();
entry = dpm_list.prev;
while (entry != &dpm_list) { while (entry != &dpm_list) {
struct device * dev = to_device(entry); struct device * dev = to_device(entry);
unsigned int hash = hash_string(DEVSEED, dev_name(dev), DEVHASH); unsigned int hash = hash_string(DEVSEED, dev_name(dev), DEVHASH);
...@@ -199,6 +201,7 @@ static int show_dev_hash(unsigned int value) ...@@ -199,6 +201,7 @@ static int show_dev_hash(unsigned int value)
} }
entry = entry->prev; entry = entry->prev;
} }
device_pm_unlock();
return match; return match;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment