Commit 2b00e30f authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab

media: imx274: fix missing return assignment from call to imx274_mode_regs

The variable ret is being checked for failure however it is not being set
from the return status from the call to imx274_mode_regs. Currently ret is
alwayus zero and the check is redundant. Fix this by assigning it.

Detected by CoverityScan, CID#1460278 ("Logically dead code")

Fixes: 0985dd30 ("media: imx274: V4l2 driver for Sony imx274 CMOS sensor")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 9917fbcf
......@@ -1059,7 +1059,7 @@ static int imx274_s_stream(struct v4l2_subdev *sd, int on)
if (on) {
/* load mode registers */
imx274_mode_regs(imx274, imx274->mode_index);
ret = imx274_mode_regs(imx274, imx274->mode_index);
if (ret)
goto fail;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment