Commit 2baa753c authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Antonio Quartulli

batman-adv: Drop immediate batadv_neigh_node free function

It is not allowed to free the memory of an object which is part of a list
which is protected by rcu-read-side-critical sections without making sure
that no other context is accessing the object anymore. This usually happens
by removing the references to this object and then waiting until the rcu
grace period is over and no one (allowedly) accesses it anymore.

But the _now functions ignore this completely. They free the object
directly even when a different context still tries to access it. This has
to be avoided and thus these functions must be removed and all functions
have to use batadv_neigh_node_free_ref.

Fixes: 89652331 ("batman-adv: split tq information in neigh_node struct")
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarAntonio Quartulli <a@unstable.cc>
parent deed9660
...@@ -284,21 +284,9 @@ static void batadv_neigh_node_free_rcu(struct rcu_head *rcu) ...@@ -284,21 +284,9 @@ static void batadv_neigh_node_free_rcu(struct rcu_head *rcu)
kfree(neigh_node); kfree(neigh_node);
} }
/**
* batadv_neigh_node_free_ref_now - decrement the neighbors refcounter
* and possibly free it (without rcu callback)
* @neigh_node: neigh neighbor to free
*/
static void
batadv_neigh_node_free_ref_now(struct batadv_neigh_node *neigh_node)
{
if (atomic_dec_and_test(&neigh_node->refcount))
batadv_neigh_node_free_rcu(&neigh_node->rcu);
}
/** /**
* batadv_neigh_node_free_ref - decrement the neighbors refcounter * batadv_neigh_node_free_ref - decrement the neighbors refcounter
* and possibly free it * and possibly release it
* @neigh_node: neigh neighbor to free * @neigh_node: neigh neighbor to free
*/ */
void batadv_neigh_node_free_ref(struct batadv_neigh_node *neigh_node) void batadv_neigh_node_free_ref(struct batadv_neigh_node *neigh_node)
...@@ -733,24 +721,23 @@ int batadv_hardif_neigh_seq_print_text(struct seq_file *seq, void *offset) ...@@ -733,24 +721,23 @@ int batadv_hardif_neigh_seq_print_text(struct seq_file *seq, void *offset)
} }
/** /**
* batadv_orig_ifinfo_free_rcu - free the orig_ifinfo object * batadv_orig_ifinfo_release - release orig_ifinfo from lists and queue for
* @rcu: rcu pointer of the orig_ifinfo object * free after rcu grace period
* @orig_ifinfo: the orig_ifinfo object to release
*/ */
static void batadv_orig_ifinfo_free_rcu(struct rcu_head *rcu) static void batadv_orig_ifinfo_release(struct batadv_orig_ifinfo *orig_ifinfo)
{ {
struct batadv_orig_ifinfo *orig_ifinfo;
struct batadv_neigh_node *router; struct batadv_neigh_node *router;
orig_ifinfo = container_of(rcu, struct batadv_orig_ifinfo, rcu);
if (orig_ifinfo->if_outgoing != BATADV_IF_DEFAULT) if (orig_ifinfo->if_outgoing != BATADV_IF_DEFAULT)
batadv_hardif_free_ref_now(orig_ifinfo->if_outgoing); batadv_hardif_free_ref(orig_ifinfo->if_outgoing);
/* this is the last reference to this object */ /* this is the last reference to this object */
router = rcu_dereference_protected(orig_ifinfo->router, true); router = rcu_dereference_protected(orig_ifinfo->router, true);
if (router) if (router)
batadv_neigh_node_free_ref_now(router); batadv_neigh_node_free_ref(router);
kfree(orig_ifinfo);
kfree_rcu(orig_ifinfo, rcu);
} }
/** /**
...@@ -761,7 +748,7 @@ static void batadv_orig_ifinfo_free_rcu(struct rcu_head *rcu) ...@@ -761,7 +748,7 @@ static void batadv_orig_ifinfo_free_rcu(struct rcu_head *rcu)
void batadv_orig_ifinfo_free_ref(struct batadv_orig_ifinfo *orig_ifinfo) void batadv_orig_ifinfo_free_ref(struct batadv_orig_ifinfo *orig_ifinfo)
{ {
if (atomic_dec_and_test(&orig_ifinfo->refcount)) if (atomic_dec_and_test(&orig_ifinfo->refcount))
call_rcu(&orig_ifinfo->rcu, batadv_orig_ifinfo_free_rcu); batadv_orig_ifinfo_release(orig_ifinfo);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment