Commit 2cd9fbd0 authored by Irina Tirdea's avatar Irina Tirdea Committed by Wolfram Sang

eeprom: at24: use i2c_smbus_read_i2c_block_data_or_emulated

For i2c busses that support only SMBUS extensions, the eeprom at24
driver reads data from the device using the SMBus block, word or byte
read protocols depending on availability.

Replace the block read emulation from the driver with the
i2c_smbus_read_i2c_block_data_or_emulated call from i2c core.
Signed-off-by: default avatarIrina Tirdea <irina.tirdea@intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 01eef96e
...@@ -186,19 +186,11 @@ static ssize_t at24_eeprom_read(struct at24_data *at24, char *buf, ...@@ -186,19 +186,11 @@ static ssize_t at24_eeprom_read(struct at24_data *at24, char *buf,
if (count > io_limit) if (count > io_limit)
count = io_limit; count = io_limit;
switch (at24->use_smbus) { if (at24->use_smbus) {
case I2C_SMBUS_I2C_BLOCK_DATA:
/* Smaller eeproms can work given some SMBus extension calls */ /* Smaller eeproms can work given some SMBus extension calls */
if (count > I2C_SMBUS_BLOCK_MAX) if (count > I2C_SMBUS_BLOCK_MAX)
count = I2C_SMBUS_BLOCK_MAX; count = I2C_SMBUS_BLOCK_MAX;
break; } else {
case I2C_SMBUS_WORD_DATA:
count = 2;
break;
case I2C_SMBUS_BYTE_DATA:
count = 1;
break;
default:
/* /*
* When we have a better choice than SMBus calls, use a * When we have a better choice than SMBus calls, use a
* combined I2C message. Write address; then read up to * combined I2C message. Write address; then read up to
...@@ -229,27 +221,10 @@ static ssize_t at24_eeprom_read(struct at24_data *at24, char *buf, ...@@ -229,27 +221,10 @@ static ssize_t at24_eeprom_read(struct at24_data *at24, char *buf,
timeout = jiffies + msecs_to_jiffies(write_timeout); timeout = jiffies + msecs_to_jiffies(write_timeout);
do { do {
read_time = jiffies; read_time = jiffies;
switch (at24->use_smbus) { if (at24->use_smbus) {
case I2C_SMBUS_I2C_BLOCK_DATA: status = i2c_smbus_read_i2c_block_data_or_emulated(client, offset,
status = i2c_smbus_read_i2c_block_data(client, offset, count, buf);
count, buf); } else {
break;
case I2C_SMBUS_WORD_DATA:
status = i2c_smbus_read_word_data(client, offset);
if (status >= 0) {
buf[0] = status & 0xff;
buf[1] = status >> 8;
status = count;
}
break;
case I2C_SMBUS_BYTE_DATA:
status = i2c_smbus_read_byte_data(client, offset);
if (status >= 0) {
buf[0] = status;
status = count;
}
break;
default:
status = i2c_transfer(client->adapter, msg, 2); status = i2c_transfer(client->adapter, msg, 2);
if (status == 2) if (status == 2)
status = count; status = count;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment