Commit 2e577f0f authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by J. Bruce Fields

NFSD fixing possible null pointer derefering in copy offload

Static checker revealed possible error path leading to possible
NULL pointer dereferencing.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: e0639dc5: ("NFSD introduce async copy feature")
Signed-off-by: default avatarOlga Kornievskaia <kolga@netapp.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent b8290ca2
...@@ -1446,7 +1446,8 @@ static void cleanup_async_copy(struct nfsd4_copy *copy) ...@@ -1446,7 +1446,8 @@ static void cleanup_async_copy(struct nfsd4_copy *copy)
{ {
nfs4_free_copy_state(copy); nfs4_free_copy_state(copy);
nfsd_file_put(copy->nf_dst); nfsd_file_put(copy->nf_dst);
nfsd_file_put(copy->nf_src); if (copy->cp_intra)
nfsd_file_put(copy->nf_src);
spin_lock(&copy->cp_clp->async_lock); spin_lock(&copy->cp_clp->async_lock);
list_del(&copy->copies); list_del(&copy->copies);
spin_unlock(&copy->cp_clp->async_lock); spin_unlock(&copy->cp_clp->async_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment