Commit 2e814af5 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab

[media] cx18: Replace memcpy with struct assignment

This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>
Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarAndy Walls <awalls@md.metrocast.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 3618acab
No related merge requests found
...@@ -240,15 +240,13 @@ int init_cx18_i2c(struct cx18 *cx) ...@@ -240,15 +240,13 @@ int init_cx18_i2c(struct cx18 *cx)
for (i = 0; i < 2; i++) { for (i = 0; i < 2; i++) {
/* Setup algorithm for adapter */ /* Setup algorithm for adapter */
memcpy(&cx->i2c_algo[i], &cx18_i2c_algo_template, cx->i2c_algo[i] = cx18_i2c_algo_template;
sizeof(struct i2c_algo_bit_data));
cx->i2c_algo_cb_data[i].cx = cx; cx->i2c_algo_cb_data[i].cx = cx;
cx->i2c_algo_cb_data[i].bus_index = i; cx->i2c_algo_cb_data[i].bus_index = i;
cx->i2c_algo[i].data = &cx->i2c_algo_cb_data[i]; cx->i2c_algo[i].data = &cx->i2c_algo_cb_data[i];
/* Setup adapter */ /* Setup adapter */
memcpy(&cx->i2c_adap[i], &cx18_i2c_adap_template, cx->i2c_adap[i] = cx18_i2c_adap_template;
sizeof(struct i2c_adapter));
cx->i2c_adap[i].algo_data = &cx->i2c_algo[i]; cx->i2c_adap[i].algo_data = &cx->i2c_algo[i];
sprintf(cx->i2c_adap[i].name + strlen(cx->i2c_adap[i].name), sprintf(cx->i2c_adap[i].name + strlen(cx->i2c_adap[i].name),
" #%d-%d", cx->instance, i); " #%d-%d", cx->instance, i);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment