Commit 2f27b81c authored by Rob Herring's avatar Rob Herring Committed by Vinod Koul

dmaengine: kill off set_irq_flags usage

set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent d078cd1b
...@@ -341,9 +341,7 @@ int __init ipu_irq_attach_irq(struct ipu *ipu, struct platform_device *dev) ...@@ -341,9 +341,7 @@ int __init ipu_irq_attach_irq(struct ipu *ipu, struct platform_device *dev)
irq_map[i].irq = irq; irq_map[i].irq = irq;
irq_map[i].source = -EINVAL; irq_map[i].source = -EINVAL;
irq_set_handler(irq, handle_level_irq); irq_set_handler(irq, handle_level_irq);
#ifdef CONFIG_ARM irq_clear_status_flags(irq, IRQ_NOREQUEST | IRQ_NOPROBE);
set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
#endif
} }
irq_set_chained_handler_and_data(ipu->irq_fn, ipu_irq_handler, ipu); irq_set_chained_handler_and_data(ipu->irq_fn, ipu_irq_handler, ipu);
...@@ -366,9 +364,7 @@ void ipu_irq_detach_irq(struct ipu *ipu, struct platform_device *dev) ...@@ -366,9 +364,7 @@ void ipu_irq_detach_irq(struct ipu *ipu, struct platform_device *dev)
irq_set_chained_handler_and_data(ipu->irq_err, NULL, NULL); irq_set_chained_handler_and_data(ipu->irq_err, NULL, NULL);
for (irq = irq_base; irq < irq_base + CONFIG_MX3_IPU_IRQS; irq++) { for (irq = irq_base; irq < irq_base + CONFIG_MX3_IPU_IRQS; irq++) {
#ifdef CONFIG_ARM irq_set_status_flags(irq, IRQ_NOREQUEST);
set_irq_flags(irq, 0);
#endif
irq_set_chip(irq, NULL); irq_set_chip(irq, NULL);
irq_set_chip_data(irq, NULL); irq_set_chip_data(irq, NULL);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment