Commit 2f28d218 authored by Madalin Bucur's avatar Madalin Bucur Committed by Scott Wood

soc/qman: Replace of_get_property() with portable equivalent

Use arch portable of_property_read_u32() instead, which takes
care of endianness conversions.
Signed-off-by: default avatarMadalin Bucur <madalin.bucur@nxp.com>
Signed-off-by: default avatarClaudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: default avatarScott Wood <oss@buserror.net>
parent 02b7d2a8
...@@ -38,6 +38,7 @@ ...@@ -38,6 +38,7 @@
#include <linux/kthread.h> #include <linux/kthread.h>
#include <linux/vmalloc.h> #include <linux/vmalloc.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/of.h>
#include <linux/of_reserved_mem.h> #include <linux/of_reserved_mem.h>
#include <linux/prefetch.h> #include <linux/prefetch.h>
#include <linux/genalloc.h> #include <linux/genalloc.h>
......
...@@ -238,9 +238,9 @@ static int qman_portal_probe(struct platform_device *pdev) ...@@ -238,9 +238,9 @@ static int qman_portal_probe(struct platform_device *pdev)
struct device_node *node = dev->of_node; struct device_node *node = dev->of_node;
struct qm_portal_config *pcfg; struct qm_portal_config *pcfg;
struct resource *addr_phys[2]; struct resource *addr_phys[2];
const u32 *channel;
void __iomem *va; void __iomem *va;
int irq, len, cpu; int irq, cpu, err;
u32 val;
pcfg = devm_kmalloc(dev, sizeof(*pcfg), GFP_KERNEL); pcfg = devm_kmalloc(dev, sizeof(*pcfg), GFP_KERNEL);
if (!pcfg) if (!pcfg)
...@@ -264,13 +264,13 @@ static int qman_portal_probe(struct platform_device *pdev) ...@@ -264,13 +264,13 @@ static int qman_portal_probe(struct platform_device *pdev)
return -ENXIO; return -ENXIO;
} }
channel = of_get_property(node, "cell-index", &len); err = of_property_read_u32(node, "cell-index", &val);
if (!channel || (len != 4)) { if (err) {
dev_err(dev, "Can't get %s property 'cell-index'\n", dev_err(dev, "Can't get %s property 'cell-index'\n",
node->full_name); node->full_name);
return -ENXIO; return err;
} }
pcfg->channel = *channel; pcfg->channel = val;
pcfg->cpu = -1; pcfg->cpu = -1;
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq <= 0) { if (irq <= 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment