Commit 2fd2bdfc authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman

staging: comedi: pcmuio: fix possible NULL deref on detach

pcmuio_detach() is called by the comedi core even if pcmuio_attach()
returned an error, so `dev->private` might be `NULL`.  Check for that
before dereferencing it.

Also, as pointed out by Dan Carpenter, there is no need to check the
pointer passed to `kfree()` is non-NULL, so remove that check.
Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b88e75bb
...@@ -672,12 +672,13 @@ static void pcmuio_detach(struct comedi_device *dev) ...@@ -672,12 +672,13 @@ static void pcmuio_detach(struct comedi_device *dev)
struct pcmuio_private *devpriv = dev->private; struct pcmuio_private *devpriv = dev->private;
int i; int i;
for (i = 0; i < PCMUIO_MAX_ASICS; ++i) { if (devpriv) {
if (devpriv->asics[i].irq) for (i = 0; i < PCMUIO_MAX_ASICS; ++i) {
free_irq(devpriv->asics[i].irq, dev); if (devpriv->asics[i].irq)
} free_irq(devpriv->asics[i].irq, dev);
if (devpriv && devpriv->sprivs) }
kfree(devpriv->sprivs); kfree(devpriv->sprivs);
}
comedi_legacy_detach(dev); comedi_legacy_detach(dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment