Commit 318a8ab7 authored by Colin Ian King's avatar Colin Ian King Committed by Doug Ledford

IB/core: remove redundant check on prot_sg_cnt

prot_sg_cnt cannot be zero as a previous check on ret (from which
prot_sg_cnt is assigned) returns -ENOMEM if is it zero.  Since
it cannot be zero we can simplify the code by removing the non
-zero check on prot_sg_cnt and redundant else statement.

Detected by CoverityScan, COD#1357188 ("Logically dead code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 9d187177
...@@ -384,21 +384,17 @@ int rdma_rw_ctx_signature_init(struct rdma_rw_ctx *ctx, struct ib_qp *qp, ...@@ -384,21 +384,17 @@ int rdma_rw_ctx_signature_init(struct rdma_rw_ctx *ctx, struct ib_qp *qp,
count += ret; count += ret;
prev_wr = &ctx->sig->data.reg_wr.wr; prev_wr = &ctx->sig->data.reg_wr.wr;
if (prot_sg_cnt) { ret = rdma_rw_init_one_mr(qp, port_num, &ctx->sig->prot,
ret = rdma_rw_init_one_mr(qp, port_num, &ctx->sig->prot, prot_sg, prot_sg_cnt, 0);
prot_sg, prot_sg_cnt, 0); if (ret < 0)
if (ret < 0) goto out_destroy_data_mr;
goto out_destroy_data_mr; count += ret;
count += ret;
if (ctx->sig->prot.inv_wr.next) if (ctx->sig->prot.inv_wr.next)
prev_wr->next = &ctx->sig->prot.inv_wr; prev_wr->next = &ctx->sig->prot.inv_wr;
else else
prev_wr->next = &ctx->sig->prot.reg_wr.wr; prev_wr->next = &ctx->sig->prot.reg_wr.wr;
prev_wr = &ctx->sig->prot.reg_wr.wr; prev_wr = &ctx->sig->prot.reg_wr.wr;
} else {
ctx->sig->prot.mr = NULL;
}
ctx->sig->sig_mr = ib_mr_pool_get(qp, &qp->sig_mrs); ctx->sig->sig_mr = ib_mr_pool_get(qp, &qp->sig_mrs);
if (!ctx->sig->sig_mr) { if (!ctx->sig->sig_mr) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment