Skip to content

L
linux
Commit 31cc48bf authored by Mark Bellon's avatar Mark Bellon Committed by Linus Torvalds
Browse files
Options

[PATCH] MPBL0010 driver sysfs permissions wide open 

The MPBL0010 Telco clock driver (drivers/char/tlclk.c) uses 0222 (anyone
can write) permissions on its writable sysfs entries.  Alter the
permissions to 0220 (owner and group can write).

The use case for this driver is to configure the fail over behavior of the
clock hardware.  That should be done by the more privileged users.
Signed-off-by: default avatarMark Bellon <mbellon@mvista.com>
Acked-by: default avatar"Gross, Mark" <mark.gross@intel.com>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 14a6283e
Hide whitespace changes
Inline Side-by-side
Showing with 18 additions and 18 deletions
drivers/char/tlclk.c
View file @ 31cc48bf
...@@ -327,7 +327,7 @@ static ssize_t store_received_ref_clk3a(struct device *d, ...@@ -327,7 +327,7 @@ static ssize_t store_received_ref_clk3a(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(received_ref_clk3a, S_IWUGO, NULL, static DEVICE_ATTR(received_ref_clk3a, (S_IWUSR|S_IWGRP), NULL,
store_received_ref_clk3a); store_received_ref_clk3a);
...@@ -349,7 +349,7 @@ static ssize_t store_received_ref_clk3b(struct device *d, ...@@ -349,7 +349,7 @@ static ssize_t store_received_ref_clk3b(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(received_ref_clk3b, S_IWUGO, NULL, static DEVICE_ATTR(received_ref_clk3b, (S_IWUSR|S_IWGRP), NULL,
store_received_ref_clk3b); store_received_ref_clk3b);
...@@ -371,7 +371,7 @@ static ssize_t store_enable_clk3b_output(struct device *d, ...@@ -371,7 +371,7 @@ static ssize_t store_enable_clk3b_output(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(enable_clk3b_output, S_IWUGO, NULL, static DEVICE_ATTR(enable_clk3b_output, (S_IWUSR|S_IWGRP), NULL,
store_enable_clk3b_output); store_enable_clk3b_output);
static ssize_t store_enable_clk3a_output(struct device *d, static ssize_t store_enable_clk3a_output(struct device *d,
...@@ -392,7 +392,7 @@ static ssize_t store_enable_clk3a_output(struct device *d, ...@@ -392,7 +392,7 @@ static ssize_t store_enable_clk3a_output(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(enable_clk3a_output, S_IWUGO, NULL, static DEVICE_ATTR(enable_clk3a_output, (S_IWUSR|S_IWGRP), NULL,
store_enable_clk3a_output); store_enable_clk3a_output);
static ssize_t store_enable_clkb1_output(struct device *d, static ssize_t store_enable_clkb1_output(struct device *d,
...@@ -413,7 +413,7 @@ static ssize_t store_enable_clkb1_output(struct device *d, ...@@ -413,7 +413,7 @@ static ssize_t store_enable_clkb1_output(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(enable_clkb1_output, S_IWUGO, NULL, static DEVICE_ATTR(enable_clkb1_output, (S_IWUSR|S_IWGRP), NULL,
store_enable_clkb1_output); store_enable_clkb1_output);
...@@ -435,7 +435,7 @@ static ssize_t store_enable_clka1_output(struct device *d, ...@@ -435,7 +435,7 @@ static ssize_t store_enable_clka1_output(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(enable_clka1_output, S_IWUGO, NULL, static DEVICE_ATTR(enable_clka1_output, (S_IWUSR|S_IWGRP), NULL,
store_enable_clka1_output); store_enable_clka1_output);
static ssize_t store_enable_clkb0_output(struct device *d, static ssize_t store_enable_clkb0_output(struct device *d,
...@@ -456,7 +456,7 @@ static ssize_t store_enable_clkb0_output(struct device *d, ...@@ -456,7 +456,7 @@ static ssize_t store_enable_clkb0_output(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(enable_clkb0_output, S_IWUGO, NULL, static DEVICE_ATTR(enable_clkb0_output, (S_IWUSR|S_IWGRP), NULL,
store_enable_clkb0_output); store_enable_clkb0_output);
static ssize_t store_enable_clka0_output(struct device *d, static ssize_t store_enable_clka0_output(struct device *d,
...@@ -477,7 +477,7 @@ static ssize_t store_enable_clka0_output(struct device *d, ...@@ -477,7 +477,7 @@ static ssize_t store_enable_clka0_output(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(enable_clka0_output, S_IWUGO, NULL, static DEVICE_ATTR(enable_clka0_output, (S_IWUSR|S_IWGRP), NULL,
store_enable_clka0_output); store_enable_clka0_output);
static ssize_t store_select_amcb2_transmit_clock(struct device *d, static ssize_t store_select_amcb2_transmit_clock(struct device *d,
...@@ -519,7 +519,7 @@ static ssize_t store_select_amcb2_transmit_clock(struct device *d, ...@@ -519,7 +519,7 @@ static ssize_t store_select_amcb2_transmit_clock(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(select_amcb2_transmit_clock, S_IWUGO, NULL, static DEVICE_ATTR(select_amcb2_transmit_clock, (S_IWUSR|S_IWGRP), NULL,
store_select_amcb2_transmit_clock); store_select_amcb2_transmit_clock);
static ssize_t store_select_amcb1_transmit_clock(struct device *d, static ssize_t store_select_amcb1_transmit_clock(struct device *d,
...@@ -560,7 +560,7 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d, ...@@ -560,7 +560,7 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(select_amcb1_transmit_clock, S_IWUGO, NULL, static DEVICE_ATTR(select_amcb1_transmit_clock, (S_IWUSR|S_IWGRP), NULL,
store_select_amcb1_transmit_clock); store_select_amcb1_transmit_clock);
static ssize_t store_select_redundant_clock(struct device *d, static ssize_t store_select_redundant_clock(struct device *d,
...@@ -581,7 +581,7 @@ static ssize_t store_select_redundant_clock(struct device *d, ...@@ -581,7 +581,7 @@ static ssize_t store_select_redundant_clock(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(select_redundant_clock, S_IWUGO, NULL, static DEVICE_ATTR(select_redundant_clock, (S_IWUSR|S_IWGRP), NULL,
store_select_redundant_clock); store_select_redundant_clock);
static ssize_t store_select_ref_frequency(struct device *d, static ssize_t store_select_ref_frequency(struct device *d,
...@@ -602,7 +602,7 @@ static ssize_t store_select_ref_frequency(struct device *d, ...@@ -602,7 +602,7 @@ static ssize_t store_select_ref_frequency(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(select_ref_frequency, S_IWUGO, NULL, static DEVICE_ATTR(select_ref_frequency, (S_IWUSR|S_IWGRP), NULL,
store_select_ref_frequency); store_select_ref_frequency);
static ssize_t store_filter_select(struct device *d, static ssize_t store_filter_select(struct device *d,
...@@ -623,7 +623,7 @@ static ssize_t store_filter_select(struct device *d, ...@@ -623,7 +623,7 @@ static ssize_t store_filter_select(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(filter_select, S_IWUGO, NULL, store_filter_select); static DEVICE_ATTR(filter_select, (S_IWUSR|S_IWGRP), NULL, store_filter_select);
static ssize_t store_hardware_switching_mode(struct device *d, static ssize_t store_hardware_switching_mode(struct device *d,
struct device_attribute *attr, const char *buf, size_t count) struct device_attribute *attr, const char *buf, size_t count)
...@@ -643,7 +643,7 @@ static ssize_t store_hardware_switching_mode(struct device *d, ...@@ -643,7 +643,7 @@ static ssize_t store_hardware_switching_mode(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(hardware_switching_mode, S_IWUGO, NULL, static DEVICE_ATTR(hardware_switching_mode, (S_IWUSR|S_IWGRP), NULL,
store_hardware_switching_mode); store_hardware_switching_mode);
static ssize_t store_hardware_switching(struct device *d, static ssize_t store_hardware_switching(struct device *d,
...@@ -664,7 +664,7 @@ static ssize_t store_hardware_switching(struct device *d, ...@@ -664,7 +664,7 @@ static ssize_t store_hardware_switching(struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(hardware_switching, S_IWUGO, NULL, static DEVICE_ATTR(hardware_switching, (S_IWUSR|S_IWGRP), NULL,
store_hardware_switching); store_hardware_switching);
static ssize_t store_refalign (struct device *d, static ssize_t store_refalign (struct device *d,
...@@ -684,7 +684,7 @@ static ssize_t store_refalign (struct device *d, ...@@ -684,7 +684,7 @@ static ssize_t store_refalign (struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(refalign, S_IWUGO, NULL, store_refalign); static DEVICE_ATTR(refalign, (S_IWUSR|S_IWGRP), NULL, store_refalign);
static ssize_t store_mode_select (struct device *d, static ssize_t store_mode_select (struct device *d,
struct device_attribute *attr, const char *buf, size_t count) struct device_attribute *attr, const char *buf, size_t count)
...@@ -704,7 +704,7 @@ static ssize_t store_mode_select (struct device *d, ...@@ -704,7 +704,7 @@ static ssize_t store_mode_select (struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(mode_select, S_IWUGO, NULL, store_mode_select); static DEVICE_ATTR(mode_select, (S_IWUSR|S_IWGRP), NULL, store_mode_select);
static ssize_t store_reset (struct device *d, static ssize_t store_reset (struct device *d,
struct device_attribute *attr, const char *buf, size_t count) struct device_attribute *attr, const char *buf, size_t count)
...@@ -724,7 +724,7 @@ static ssize_t store_reset (struct device *d, ...@@ -724,7 +724,7 @@ static ssize_t store_reset (struct device *d,
return strnlen(buf, count); return strnlen(buf, count);
} }
static DEVICE_ATTR(reset, S_IWUGO, NULL, store_reset); static DEVICE_ATTR(reset, (S_IWUSR|S_IWGRP), NULL, store_reset);
static struct attribute *tlclk_sysfs_entries[] = { static struct attribute *tlclk_sysfs_entries[] = {
&dev_attr_current_ref.attr, &dev_attr_current_ref.attr,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7