Commit 329cabce authored by Stephen Boyd's avatar Stephen Boyd

clk: qcom: Specify LE device endianness

All these clock controllers are little endian devices, but so far
we've been relying on the regmap mmio bus handling this for us
without explicitly stating that fact. After commit 4a98da2164cf
(regmap-mmio: Use native endianness for read/write, 2015-10-29),
the regmap mmio bus will read/write with the __raw_*() IO
accessors, instead of using the readl/writel() APIs that do
proper byte swapping for little endian devices.

So if we're running on a big endian processor and haven't
specified the endianness explicitly in the regmap config or in
DT, we're going to switch from doing little endian byte swapping
to big endian accesses without byte swapping, leading to some
confusing results. On my apq8074 dragonboard, this causes the
device to fail to boot as we access the clock controller with
big endian IO accesses even though the device is little endian.

Specify the endianness explicitly so that the regmap core
properly byte swaps the accesses for us.
Reported-by: default avatarKevin Hilman <khilman@linaro.org>
Tested-by: default avatarTyler Baker <tyler.baker@linaro.org>
Tested-by: default avatarKevin Hilman <khilman@linaro.org>
Cc: Simon Arlott <simon@fire.lp0.eu>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 96cb6933
...@@ -3587,6 +3587,7 @@ static const struct regmap_config gcc_apq8084_regmap_config = { ...@@ -3587,6 +3587,7 @@ static const struct regmap_config gcc_apq8084_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x1fc0, .max_register = 0x1fc0,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc gcc_apq8084_desc = { static const struct qcom_cc_desc gcc_apq8084_desc = {
......
...@@ -3005,6 +3005,7 @@ static const struct regmap_config gcc_ipq806x_regmap_config = { ...@@ -3005,6 +3005,7 @@ static const struct regmap_config gcc_ipq806x_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x3e40, .max_register = 0x3e40,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc gcc_ipq806x_desc = { static const struct qcom_cc_desc gcc_ipq806x_desc = {
......
...@@ -2702,6 +2702,7 @@ static const struct regmap_config gcc_msm8660_regmap_config = { ...@@ -2702,6 +2702,7 @@ static const struct regmap_config gcc_msm8660_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x363c, .max_register = 0x363c,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc gcc_msm8660_desc = { static const struct qcom_cc_desc gcc_msm8660_desc = {
......
...@@ -3336,6 +3336,7 @@ static const struct regmap_config gcc_msm8916_regmap_config = { ...@@ -3336,6 +3336,7 @@ static const struct regmap_config gcc_msm8916_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x80000, .max_register = 0x80000,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc gcc_msm8916_desc = { static const struct qcom_cc_desc gcc_msm8916_desc = {
......
...@@ -3468,6 +3468,7 @@ static const struct regmap_config gcc_msm8960_regmap_config = { ...@@ -3468,6 +3468,7 @@ static const struct regmap_config gcc_msm8960_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x3660, .max_register = 0x3660,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct regmap_config gcc_apq8064_regmap_config = { static const struct regmap_config gcc_apq8064_regmap_config = {
...@@ -3476,6 +3477,7 @@ static const struct regmap_config gcc_apq8064_regmap_config = { ...@@ -3476,6 +3477,7 @@ static const struct regmap_config gcc_apq8064_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x3880, .max_register = 0x3880,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc gcc_msm8960_desc = { static const struct qcom_cc_desc gcc_msm8960_desc = {
......
...@@ -2680,6 +2680,7 @@ static const struct regmap_config gcc_msm8974_regmap_config = { ...@@ -2680,6 +2680,7 @@ static const struct regmap_config gcc_msm8974_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x1fc0, .max_register = 0x1fc0,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc gcc_msm8974_desc = { static const struct qcom_cc_desc gcc_msm8974_desc = {
......
...@@ -419,6 +419,7 @@ static const struct regmap_config lcc_ipq806x_regmap_config = { ...@@ -419,6 +419,7 @@ static const struct regmap_config lcc_ipq806x_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0xfc, .max_register = 0xfc,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc lcc_ipq806x_desc = { static const struct qcom_cc_desc lcc_ipq806x_desc = {
......
...@@ -524,6 +524,7 @@ static const struct regmap_config lcc_msm8960_regmap_config = { ...@@ -524,6 +524,7 @@ static const struct regmap_config lcc_msm8960_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0xfc, .max_register = 0xfc,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc lcc_msm8960_desc = { static const struct qcom_cc_desc lcc_msm8960_desc = {
......
...@@ -3368,6 +3368,7 @@ static const struct regmap_config mmcc_apq8084_regmap_config = { ...@@ -3368,6 +3368,7 @@ static const struct regmap_config mmcc_apq8084_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x5104, .max_register = 0x5104,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc mmcc_apq8084_desc = { static const struct qcom_cc_desc mmcc_apq8084_desc = {
......
...@@ -3029,6 +3029,7 @@ static const struct regmap_config mmcc_msm8960_regmap_config = { ...@@ -3029,6 +3029,7 @@ static const struct regmap_config mmcc_msm8960_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x334, .max_register = 0x334,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct regmap_config mmcc_apq8064_regmap_config = { static const struct regmap_config mmcc_apq8064_regmap_config = {
...@@ -3037,6 +3038,7 @@ static const struct regmap_config mmcc_apq8064_regmap_config = { ...@@ -3037,6 +3038,7 @@ static const struct regmap_config mmcc_apq8064_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x350, .max_register = 0x350,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc mmcc_msm8960_desc = { static const struct qcom_cc_desc mmcc_msm8960_desc = {
......
...@@ -2594,6 +2594,7 @@ static const struct regmap_config mmcc_msm8974_regmap_config = { ...@@ -2594,6 +2594,7 @@ static const struct regmap_config mmcc_msm8974_regmap_config = {
.val_bits = 32, .val_bits = 32,
.max_register = 0x5104, .max_register = 0x5104,
.fast_io = true, .fast_io = true,
.val_format_endian = REGMAP_ENDIAN_LITTLE,
}; };
static const struct qcom_cc_desc mmcc_msm8974_desc = { static const struct qcom_cc_desc mmcc_msm8974_desc = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment