Commit 3589cce2 authored by Jaejoong Kim's avatar Jaejoong Kim Committed by Felipe Balbi

usb: gadget: udc: Use scnprintf() instead of snprintf()

The show() method should use scnprintf() not snprintf() because snprintf()
may returns a value that exceeds its second argument.
Signed-off-by: default avatarJaejoong Kim <climbbb.kim@gmail.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent daaecc65
...@@ -1482,7 +1482,7 @@ ssize_t name##_show(struct device *dev, \ ...@@ -1482,7 +1482,7 @@ ssize_t name##_show(struct device *dev, \
struct device_attribute *attr, char *buf) \ struct device_attribute *attr, char *buf) \
{ \ { \
struct usb_udc *udc = container_of(dev, struct usb_udc, dev); \ struct usb_udc *udc = container_of(dev, struct usb_udc, dev); \
return snprintf(buf, PAGE_SIZE, "%s\n", \ return scnprintf(buf, PAGE_SIZE, "%s\n", \
usb_speed_string(udc->gadget->param)); \ usb_speed_string(udc->gadget->param)); \
} \ } \
static DEVICE_ATTR_RO(name) static DEVICE_ATTR_RO(name)
...@@ -1497,7 +1497,7 @@ ssize_t name##_show(struct device *dev, \ ...@@ -1497,7 +1497,7 @@ ssize_t name##_show(struct device *dev, \
struct usb_udc *udc = container_of(dev, struct usb_udc, dev); \ struct usb_udc *udc = container_of(dev, struct usb_udc, dev); \
struct usb_gadget *gadget = udc->gadget; \ struct usb_gadget *gadget = udc->gadget; \
\ \
return snprintf(buf, PAGE_SIZE, "%d\n", gadget->name); \ return scnprintf(buf, PAGE_SIZE, "%d\n", gadget->name); \
} \ } \
static DEVICE_ATTR_RO(name) static DEVICE_ATTR_RO(name)
......
...@@ -2366,7 +2366,7 @@ static inline ssize_t show_urb(char *buf, size_t size, struct urb *urb) ...@@ -2366,7 +2366,7 @@ static inline ssize_t show_urb(char *buf, size_t size, struct urb *urb)
{ {
int ep = usb_pipeendpoint(urb->pipe); int ep = usb_pipeendpoint(urb->pipe);
return snprintf(buf, size, return scnprintf(buf, size,
"urb/%p %s ep%d%s%s len %d/%d\n", "urb/%p %s ep%d%s%s len %d/%d\n",
urb, urb,
({ char *s; ({ char *s;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment