Commit 3606189f authored by Paolo Bonzini's avatar Paolo Bonzini

KVM: emulator: fix error code for __linearize

The error code for #GP and #SS is zero when the segment is used to
access an operand or an instruction.  It is only non-zero when
a segment register is being loaded; for limit checks this means
cases such as:

* for #GP, when RIP is beyond the limit on a far call (before the first
instruction is executed).  We do not implement this check, but it
would be in em_jmp_far/em_call_far.

* for #SS, if the new stack overflows during an inter-privilege-level
call to a non-conforming code segment.  We do not implement stack
switching at all.

So use an error code of zero.
Reviewed-by: default avatarNadav Amit <namit@cs.technion.ac.il>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent cac7f242
...@@ -711,9 +711,9 @@ static int __linearize(struct x86_emulate_ctxt *ctxt, ...@@ -711,9 +711,9 @@ static int __linearize(struct x86_emulate_ctxt *ctxt,
return X86EMUL_CONTINUE; return X86EMUL_CONTINUE;
bad: bad:
if (addr.seg == VCPU_SREG_SS) if (addr.seg == VCPU_SREG_SS)
return emulate_ss(ctxt, sel); return emulate_ss(ctxt, 0);
else else
return emulate_gp(ctxt, sel); return emulate_gp(ctxt, 0);
} }
static int linearize(struct x86_emulate_ctxt *ctxt, static int linearize(struct x86_emulate_ctxt *ctxt,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment