Commit 360914d6 authored by Dave Chinner's avatar Dave Chinner Committed by Willy Tarreau

xfs: fix inode validity check in xfs_iflush_cluster

commit 51b07f30 upstream.

Some careless idiot(*) wrote crap code in commit 1a3e8f3d ("xfs:
convert inode cache lookups to use RCU locking") back in late 2010,
and so xfs_iflush_cluster checks the wrong inode for whether it is
still valid under RCU protection. Fix it to lock and check the
correct inode.

(*) Careless-idiot: Dave Chinner <dchinner@redhat.com>

cc: <stable@vger.kernel.org> # 3.10.x-
Discovered-by: default avatarBrain Foster <bfoster@redhat.com>
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
parent 01ee4801
......@@ -2604,13 +2604,13 @@ xfs_iflush_cluster(
* We need to check under the i_flags_lock for a valid inode
* here. Skip it if it is not valid or the wrong inode.
*/
spin_lock(&ip->i_flags_lock);
if (!ip->i_ino ||
spin_lock(&iq->i_flags_lock);
if (!iq->i_ino ||
(XFS_INO_TO_AGINO(mp, iq->i_ino) & mask) != first_index) {
spin_unlock(&ip->i_flags_lock);
spin_unlock(&iq->i_flags_lock);
continue;
}
spin_unlock(&ip->i_flags_lock);
spin_unlock(&iq->i_flags_lock);
/*
* Do an un-protected check to see if the inode is dirty and
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment