Commit 3820061d authored by Xu Yilun's avatar Xu Yilun Committed by Mark Brown

spi: altera: support indirect access to the registers

This patch adds support for indirect access to the registers via parent
regmap.

The use case is, the spi master is a sub device of a Multifunction
device, which is connected to host by some indirect bus. To support this
device type, a new platform_device_id is introduced, and the driver tries
to get parent regmap for register accessing like many MFD sub device
drivers do.
Signed-off-by: default avatarXu Yilun <yilun.xu@intel.com>
Signed-off-by: default avatarMatthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: default avatarWu Hao <hao.wu@intel.com>
Signed-off-by: default avatarRuss Weight <russell.h.weight@intel.com>
Reviewed-by: default avatarTom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/1592531021-11412-3-git-send-email-yilun.xu@intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3c651973
...@@ -43,6 +43,11 @@ ...@@ -43,6 +43,11 @@
#define ALTERA_SPI_MAX_CS 32 #define ALTERA_SPI_MAX_CS 32
enum altera_spi_type {
ALTERA_SPI_TYPE_UNKNOWN,
ALTERA_SPI_TYPE_SUBDEV,
};
struct altera_spi { struct altera_spi {
int irq; int irq;
int len; int len;
...@@ -55,6 +60,7 @@ struct altera_spi { ...@@ -55,6 +60,7 @@ struct altera_spi {
unsigned char *rx; unsigned char *rx;
struct regmap *regmap; struct regmap *regmap;
u32 regoff;
struct device *dev; struct device *dev;
}; };
...@@ -70,7 +76,7 @@ static int altr_spi_writel(struct altera_spi *hw, unsigned int reg, ...@@ -70,7 +76,7 @@ static int altr_spi_writel(struct altera_spi *hw, unsigned int reg,
{ {
int ret; int ret;
ret = regmap_write(hw->regmap, reg, val); ret = regmap_write(hw->regmap, hw->regoff + reg, val);
if (ret) if (ret)
dev_err(hw->dev, "fail to write reg 0x%x val 0x%x: %d\n", dev_err(hw->dev, "fail to write reg 0x%x val 0x%x: %d\n",
reg, val, ret); reg, val, ret);
...@@ -83,7 +89,7 @@ static int altr_spi_readl(struct altera_spi *hw, unsigned int reg, ...@@ -83,7 +89,7 @@ static int altr_spi_readl(struct altera_spi *hw, unsigned int reg,
{ {
int ret; int ret;
ret = regmap_read(hw->regmap, reg, val); ret = regmap_read(hw->regmap, hw->regoff + reg, val);
if (ret) if (ret)
dev_err(hw->dev, "fail to read reg 0x%x: %d\n", reg, ret); dev_err(hw->dev, "fail to read reg 0x%x: %d\n", reg, ret);
...@@ -225,10 +231,11 @@ static irqreturn_t altera_spi_irq(int irq, void *dev) ...@@ -225,10 +231,11 @@ static irqreturn_t altera_spi_irq(int irq, void *dev)
static int altera_spi_probe(struct platform_device *pdev) static int altera_spi_probe(struct platform_device *pdev)
{ {
const struct platform_device_id *platid = platform_get_device_id(pdev);
struct altera_spi_platform_data *pdata = dev_get_platdata(&pdev->dev); struct altera_spi_platform_data *pdata = dev_get_platdata(&pdev->dev);
enum altera_spi_type type = ALTERA_SPI_TYPE_UNKNOWN;
struct altera_spi *hw; struct altera_spi *hw;
struct spi_master *master; struct spi_master *master;
void __iomem *res;
int err = -ENODEV; int err = -ENODEV;
u32 val; u32 val;
u16 i; u16 i;
...@@ -264,19 +271,38 @@ static int altera_spi_probe(struct platform_device *pdev) ...@@ -264,19 +271,38 @@ static int altera_spi_probe(struct platform_device *pdev)
hw = spi_master_get_devdata(master); hw = spi_master_get_devdata(master);
hw->dev = &pdev->dev; hw->dev = &pdev->dev;
if (platid)
type = platid->driver_data;
/* find and map our resources */ /* find and map our resources */
res = devm_platform_ioremap_resource(pdev, 0); if (type == ALTERA_SPI_TYPE_SUBDEV) {
if (IS_ERR(res)) { struct resource *regoff;
err = PTR_ERR(res);
goto exit;
}
hw->regmap = devm_regmap_init_mmio(&pdev->dev, res, hw->regmap = dev_get_regmap(pdev->dev.parent, NULL);
&spi_altera_config); if (!hw->regmap) {
if (IS_ERR(hw->regmap)) { dev_err(&pdev->dev, "get regmap failed\n");
dev_err(&pdev->dev, "regmap mmio init failed\n"); goto exit;
err = PTR_ERR(hw->regmap); }
goto exit;
regoff = platform_get_resource(pdev, IORESOURCE_REG, 0);
if (regoff)
hw->regoff = regoff->start;
} else {
void __iomem *res;
res = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(res)) {
err = PTR_ERR(res);
goto exit;
}
hw->regmap = devm_regmap_init_mmio(&pdev->dev, res,
&spi_altera_config);
if (IS_ERR(hw->regmap)) {
dev_err(&pdev->dev, "regmap mmio init failed\n");
err = PTR_ERR(hw->regmap);
goto exit;
}
} }
/* program defaults into the registers */ /* program defaults into the registers */
...@@ -308,7 +334,7 @@ static int altera_spi_probe(struct platform_device *pdev) ...@@ -308,7 +334,7 @@ static int altera_spi_probe(struct platform_device *pdev)
} }
} }
dev_info(&pdev->dev, "base %p, irq %d\n", res, hw->irq); dev_info(&pdev->dev, "regoff %u, irq %d\n", hw->regoff, hw->irq);
return 0; return 0;
exit: exit:
...@@ -325,6 +351,11 @@ static const struct of_device_id altera_spi_match[] = { ...@@ -325,6 +351,11 @@ static const struct of_device_id altera_spi_match[] = {
MODULE_DEVICE_TABLE(of, altera_spi_match); MODULE_DEVICE_TABLE(of, altera_spi_match);
#endif /* CONFIG_OF */ #endif /* CONFIG_OF */
static const struct platform_device_id altera_spi_ids[] = {
{ "subdev_spi_altera", ALTERA_SPI_TYPE_SUBDEV },
{ }
};
static struct platform_driver altera_spi_driver = { static struct platform_driver altera_spi_driver = {
.probe = altera_spi_probe, .probe = altera_spi_probe,
.driver = { .driver = {
...@@ -332,6 +363,7 @@ static struct platform_driver altera_spi_driver = { ...@@ -332,6 +363,7 @@ static struct platform_driver altera_spi_driver = {
.pm = NULL, .pm = NULL,
.of_match_table = of_match_ptr(altera_spi_match), .of_match_table = of_match_ptr(altera_spi_match),
}, },
.id_table = altera_spi_ids,
}; };
module_platform_driver(altera_spi_driver); module_platform_driver(altera_spi_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment