Commit 39c4dbe4 authored by Hanks Chen's avatar Hanks Chen Committed by Linus Walleij

pinctrl: mediatek: check mtk_is_virt_gpio input parameter

check mtk_is_virt_gpio input parameter,
virtual gpio need to support eint mode.

add error handler for the ko case
to fix this boot fail:
pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]

Fixes: edd54646 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
Signed-off-by: default avatarHanks Chen <hanks.chen@mediatek.com>
Acked-by: default avatarSean Wang <sean.wang@kernel.org>
Singed-off-by: default avatarJie Yang <sin_jieyang@mediatek.com>
Link: https://lore.kernel.org/r/1597922546-29633-1-git-send-email-hanks.chen@mediatek.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5d8ff95a
...@@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n) ...@@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n]; desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
/* if the GPIO is not supported for eint mode */
if (desc->eint.eint_m == NO_EINT_SUPPORT)
return virt_gpio;
if (desc->funcs && !desc->funcs[desc->eint.eint_m].name) if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
virt_gpio = true; virt_gpio = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment