Commit 3a6de292 authored by NeilBrown's avatar NeilBrown

md/raid5: Mark device want_replacement when we see a write error.

Now that WantReplacement drives are replaced cleanly, mark a drive
as WantReplacement when we see a write error.  It might get failed soon so
the WantReplacement flag is irrelevant, but if the write error is recorded
in the bad block log, we still want to activate any spare that might
be available.
Reviewed-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 7bfec5f3
...@@ -1796,6 +1796,9 @@ static void raid5_end_write_request(struct bio *bi, int error) ...@@ -1796,6 +1796,9 @@ static void raid5_end_write_request(struct bio *bi, int error)
if (!uptodate) { if (!uptodate) {
set_bit(WriteErrorSeen, &rdev->flags); set_bit(WriteErrorSeen, &rdev->flags);
set_bit(R5_WriteError, &sh->dev[i].flags); set_bit(R5_WriteError, &sh->dev[i].flags);
if (!test_and_set_bit(WantReplacement, &rdev->flags))
set_bit(MD_RECOVERY_NEEDED,
&rdev->mddev->recovery);
} else if (is_badblock(rdev, sh->sector, } else if (is_badblock(rdev, sh->sector,
STRIPE_SECTORS, STRIPE_SECTORS,
&first_bad, &bad_sectors)) &first_bad, &bad_sectors))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment