Commit 3b52ce44 authored by Chris Wilson's avatar Chris Wilson Committed by Gustavo Padovan

dma-buf/sw-sync: sync_pt is private and of fixed size

Since sync_pt is only allocated from a single location and is no longer
the base class for fences (that is struct dma_fence) it no longer needs
a generic unsized allocator.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarGustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170629125930.821-5-chris@chris-wilson.co.uk
parent a6aa8fca
...@@ -155,7 +155,6 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc) ...@@ -155,7 +155,6 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc)
/** /**
* sync_pt_create() - creates a sync pt * sync_pt_create() - creates a sync pt
* @parent: fence's parent sync_timeline * @parent: fence's parent sync_timeline
* @size: size to allocate for this pt
* @inc: value of the fence * @inc: value of the fence
* *
* Creates a new sync_pt as a child of @parent. @size bytes will be * Creates a new sync_pt as a child of @parent. @size bytes will be
...@@ -163,15 +162,12 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc) ...@@ -163,15 +162,12 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc)
* the generic sync_timeline struct. Returns the sync_pt object or * the generic sync_timeline struct. Returns the sync_pt object or
* NULL in case of error. * NULL in case of error.
*/ */
static struct sync_pt *sync_pt_create(struct sync_timeline *obj, int size, static struct sync_pt *sync_pt_create(struct sync_timeline *obj,
unsigned int value) unsigned int value)
{ {
struct sync_pt *pt; struct sync_pt *pt;
if (size < sizeof(*pt)) pt = kzalloc(sizeof(*pt), GFP_KERNEL);
return NULL;
pt = kzalloc(size, GFP_KERNEL);
if (!pt) if (!pt)
return NULL; return NULL;
...@@ -312,7 +308,7 @@ static long sw_sync_ioctl_create_fence(struct sync_timeline *obj, ...@@ -312,7 +308,7 @@ static long sw_sync_ioctl_create_fence(struct sync_timeline *obj,
goto err; goto err;
} }
pt = sync_pt_create(obj, sizeof(*pt), data.value); pt = sync_pt_create(obj, data.value);
if (!pt) { if (!pt) {
err = -ENOMEM; err = -ENOMEM;
goto err; goto err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment