Commit 3cf6ed75 authored by Keerthy's avatar Keerthy Committed by Ben Hutchings

bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler

commit c4cf0935 upstream.

Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.

Fixes: 2722e56d ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: default avatarNishanth Menon <nm@ti.com>
Signed-off-by: default avatarKeerthy <j-keerthy@ti.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
[bwh: Backported to 3.2: adjust filename, indentation]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 27bdcd72
...@@ -121,11 +121,15 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3) ...@@ -121,11 +121,15 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3)
/* Nothing to be handled here as of now */ /* Nothing to be handled here as of now */
break; break;
} }
/* Error found so break the for loop */ /* Error found so break the for loop */
break; return IRQ_HANDLED;
} }
} }
return IRQ_HANDLED;
dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
inttype ? "debug" : "application");
return IRQ_NONE;
} }
static int __devinit omap4_l3_probe(struct platform_device *pdev) static int __devinit omap4_l3_probe(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment