Commit 3d311cb2 authored by Anton Blanchard's avatar Anton Blanchard Committed by Linus Torvalds

[PATCH] ppc64: Fix rtas_set_indicator(9005)

It turns out we were passing in the wrong thing to the rtas_set_indicator
call.  Luckily we got away with it because it looks like firmware does not
check arguments and just inserts or removes the current cpu from the global
server group.

Fix it.
Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d00da3f8
...@@ -265,7 +265,8 @@ static void __devinit smp_xics_setup_cpu(int cpu) ...@@ -265,7 +265,8 @@ static void __devinit smp_xics_setup_cpu(int cpu)
* necessary from a secondary thread as the OF start-cpu interface * necessary from a secondary thread as the OF start-cpu interface
* performs this function for us on primary threads. * performs this function for us on primary threads.
*/ */
rtas_set_indicator(GLOBAL_INTERRUPT_QUEUE, default_distrib_server, 1); rtas_set_indicator(GLOBAL_INTERRUPT_QUEUE,
(1UL << interrupt_server_size) - 1 - default_distrib_server, 1);
#endif #endif
} }
......
...@@ -91,6 +91,7 @@ static int xics_irq_8259_cascade_real = 0; ...@@ -91,6 +91,7 @@ static int xics_irq_8259_cascade_real = 0;
static unsigned int default_server = 0xFF; static unsigned int default_server = 0xFF;
/* also referenced in smp.c... */ /* also referenced in smp.c... */
unsigned int default_distrib_server = 0; unsigned int default_distrib_server = 0;
unsigned int interrupt_server_size = 8;
/* /*
* XICS only has a single IPI, so encode the messages per CPU * XICS only has a single IPI, so encode the messages per CPU
...@@ -511,6 +512,10 @@ void xics_init_IRQ(void) ...@@ -511,6 +512,10 @@ void xics_init_IRQ(void)
default_server = ireg[0]; default_server = ireg[0];
default_distrib_server = ireg[i-1]; /* take last element */ default_distrib_server = ireg[i-1]; /* take last element */
} }
ireg = (uint *)get_property(np,
"ibm,interrupt-server#-size", NULL);
if (ireg)
interrupt_server_size = *ireg;
break; break;
} }
} }
...@@ -650,9 +655,9 @@ void xics_migrate_irqs_away(void) ...@@ -650,9 +655,9 @@ void xics_migrate_irqs_away(void)
ops->cppr_info(cpu, 0); ops->cppr_info(cpu, 0);
iosync(); iosync();
/* Refuse any new interrupts... */ /* remove ourselves from the global interrupt queue */
status = rtas_set_indicator(GLOBAL_INTERRUPT_QUEUE, status = rtas_set_indicator(GLOBAL_INTERRUPT_QUEUE,
hard_smp_processor_id(), 0); (1UL << interrupt_server_size) - 1 - default_distrib_server, 0);
WARN_ON(status != 0); WARN_ON(status != 0);
/* Allow IPIs again... */ /* Allow IPIs again... */
......
...@@ -31,5 +31,6 @@ struct xics_ipi_struct { ...@@ -31,5 +31,6 @@ struct xics_ipi_struct {
extern struct xics_ipi_struct xics_ipi_message[NR_CPUS] __cacheline_aligned; extern struct xics_ipi_struct xics_ipi_message[NR_CPUS] __cacheline_aligned;
extern unsigned int default_distrib_server; extern unsigned int default_distrib_server;
extern unsigned int interrupt_server_size;
#endif /* _PPC64_KERNEL_XICS_H */ #endif /* _PPC64_KERNEL_XICS_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment