Commit 3e6b2cfa authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Ben Hutchings

sata_fsl: fix error handling of irq_of_parse_and_map

commit aad0b624 upstream.

irq_of_parse_and_map() returns 0 on error (the result is unsigned int),
so testing for negative result never works.
Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent c310193a
...@@ -1338,7 +1338,7 @@ static int sata_fsl_probe(struct platform_device *ofdev) ...@@ -1338,7 +1338,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
host_priv->csr_base = csr_base; host_priv->csr_base = csr_base;
irq = irq_of_parse_and_map(ofdev->dev.of_node, 0); irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
if (irq < 0) { if (!irq) {
dev_err(&ofdev->dev, "invalid irq from platform\n"); dev_err(&ofdev->dev, "invalid irq from platform\n");
goto error_exit_with_cleanup; goto error_exit_with_cleanup;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment