Commit 3f2ce542 authored by Thomas Zimmermann's avatar Thomas Zimmermann Committed by Bartlomiej Zolnierkiewicz

fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set

If the console is unlocked during registration, the console subsystem
generates significant amounts of warnings, which obfuscate actual
debugging messages. Setting ignore_console_lock_warning while debugging
console registration avoid the noise.

v3:
	- manipulate ignore_console_lock_warning with atomic_{inc,dec}
v2:
	- restore ignore_console_lock_warning if lock_fb_info() fails
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Reviewed-by: default avatarSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent 56e6c104
...@@ -1690,17 +1690,22 @@ static int do_register_framebuffer(struct fb_info *fb_info) ...@@ -1690,17 +1690,22 @@ static int do_register_framebuffer(struct fb_info *fb_info)
event.info = fb_info; event.info = fb_info;
if (!lockless_register_fb) if (!lockless_register_fb)
console_lock(); console_lock();
else
atomic_inc(&ignore_console_lock_warning);
if (!lock_fb_info(fb_info)) { if (!lock_fb_info(fb_info)) {
if (!lockless_register_fb) ret = -ENODEV;
console_unlock(); goto unlock_console;
return -ENODEV;
} }
ret = 0;
fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event); fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event);
unlock_fb_info(fb_info); unlock_fb_info(fb_info);
unlock_console:
if (!lockless_register_fb) if (!lockless_register_fb)
console_unlock(); console_unlock();
return 0; else
atomic_dec(&ignore_console_lock_warning);
return ret;
} }
static int unbind_console(struct fb_info *fb_info) static int unbind_console(struct fb_info *fb_info)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment