Commit 4047488d authored by Rainer Weikusat's avatar Rainer Weikusat Committed by Kamal Mostafa

af_unix: Don't set err in unix_stream_read_generic unless there was an error

commit 1b92ee3d upstream.

The present unix_stream_read_generic contains various code sequences of
the form

err = -EDISASTER;
if (<test>)
	goto out;

This has the unfortunate side effect of possibly causing the error code
to bleed through to the final

out:
	return copied ? : err;

and then to be wrongly returned if no data was copied because the caller
didn't supply a data buffer, as demonstrated by the program available at

http://pad.lv/1540731

Change it such that err is only set if an error condition was detected.

Fixes: 3822b5c2 ("af_unix: Revert 'lock_interruptible' in stream receive code")
Reported-by: default avatarJoseph Salisbury <joseph.salisbury@canonical.com>
Signed-off-by: default avatarRainer Weikusat <rweikusat@mobileactivedefense.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent e2a5de9f
...@@ -2274,13 +2274,15 @@ static int unix_stream_read_generic(struct unix_stream_read_state *state) ...@@ -2274,13 +2274,15 @@ static int unix_stream_read_generic(struct unix_stream_read_state *state)
size_t size = state->size; size_t size = state->size;
unsigned int last_len; unsigned int last_len;
err = -EINVAL; if (unlikely(sk->sk_state != TCP_ESTABLISHED)) {
if (sk->sk_state != TCP_ESTABLISHED) err = -EINVAL;
goto out; goto out;
}
err = -EOPNOTSUPP; if (unlikely(flags & MSG_OOB)) {
if (flags & MSG_OOB) err = -EOPNOTSUPP;
goto out; goto out;
}
target = sock_rcvlowat(sk, flags & MSG_WAITALL, size); target = sock_rcvlowat(sk, flags & MSG_WAITALL, size);
timeo = sock_rcvtimeo(sk, noblock); timeo = sock_rcvtimeo(sk, noblock);
...@@ -2326,9 +2328,11 @@ static int unix_stream_read_generic(struct unix_stream_read_state *state) ...@@ -2326,9 +2328,11 @@ static int unix_stream_read_generic(struct unix_stream_read_state *state)
goto unlock; goto unlock;
unix_state_unlock(sk); unix_state_unlock(sk);
err = -EAGAIN; if (!timeo) {
if (!timeo) err = -EAGAIN;
break; break;
}
mutex_unlock(&u->readlock); mutex_unlock(&u->readlock);
timeo = unix_stream_data_wait(sk, timeo, last, timeo = unix_stream_data_wait(sk, timeo, last,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment