Commit 4178549e authored by Cláudio Maia's avatar Cláudio Maia Committed by Greg Kroah-Hartman

Staging: fbtft: fb_pcd8544: Fix comments style

This patch fixes the following errors by refactoring the comments'
style:

WARNING: line over 80 characters
ERROR: code indent should use tabs where possible
Signed-off-by: default avatarCláudio Maia <crrm@isep.ipp.pt>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 14cf23b1
...@@ -34,7 +34,7 @@ ...@@ -34,7 +34,7 @@
#define WIDTH 84 #define WIDTH 84
#define HEIGHT 48 #define HEIGHT 48
#define TXBUFLEN (84*6) #define TXBUFLEN (84*6)
#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */ #define DEFAULT_GAMMA "40" /* gamma controls the contrast in this driver */
static unsigned tc; static unsigned tc;
module_param(tc, uint, 0); module_param(tc, uint, 0);
...@@ -51,43 +51,50 @@ static int init_display(struct fbtft_par *par) ...@@ -51,43 +51,50 @@ static int init_display(struct fbtft_par *par)
par->fbtftops.reset(par); par->fbtftops.reset(par);
/* Function set */ /* Function set
write_reg(par, 0x21); /* 5:1 1 *
2:0 PD - Powerdown control: chip is active * 5:1 1
1:0 V - Entry mode: horizontal addressing * 2:0 PD - Powerdown control: chip is active
0:1 H - Extended instruction set control: extended * 1:0 V - Entry mode: horizontal addressing
*/ * 0:1 H - Extended instruction set control: extended
*/
/* H=1 Temperature control */ write_reg(par, 0x21);
write_reg(par, 0x04 | (tc & 0x3)); /*
2:1 1 /* H=1 Temperature control
1:x TC1 - Temperature Coefficient: 0x10 *
0:x TC0 * 2:1 1
*/ * 1:x TC1 - Temperature Coefficient: 0x10
* 0:x TC0
/* H=1 Bias system */ */
write_reg(par, 0x10 | (bs & 0x7)); /* write_reg(par, 0x04 | (tc & 0x3));
4:1 1
3:0 0 /* H=1 Bias system
2:x BS2 - Bias System *
1:x BS1 * 4:1 1
0:x BS0 * 3:0 0
*/ * 2:x BS2 - Bias System
* 1:x BS1
/* Function set */ * 0:x BS0
write_reg(par, 0x22); /* 5:1 1 */
2:0 PD - Powerdown control: chip is active write_reg(par, 0x10 | (bs & 0x7));
1:1 V - Entry mode: vertical addressing
0:0 H - Extended instruction set control: basic /* Function set
*/ *
* 5:1 1
/* H=0 Display control */ * 2:0 PD - Powerdown control: chip is active
write_reg(par, 0x08 | 4); /* * 1:1 V - Entry mode: vertical addressing
3:1 1 * 0:0 H - Extended instruction set control: basic
2:1 D - DE: 10=normal mode */
1:0 0 write_reg(par, 0x22);
0:0 E
*/ /* H=0 Display control
*
* 3:1 1
* 2:1 D - DE: 10=normal mode
* 1:0 0
* 0:0 E
*/
write_reg(par, 0x08 | 4);
return 0; return 0;
} }
...@@ -97,16 +104,20 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) ...@@ -97,16 +104,20 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n",
__func__, xs, ys, xe, ye); __func__, xs, ys, xe, ye);
/* H=0 Set X address of RAM */ /* H=0 Set X address of RAM
write_reg(par, 0x80); /* 7:1 1 *
6-0: X[6:0] - 0x00 * 7:1 1
*/ * 6-0: X[6:0] - 0x00
*/
/* H=0 Set Y address of RAM */ write_reg(par, 0x80);
write_reg(par, 0x40); /* 7:0 0
6:1 1 /* H=0 Set Y address of RAM
2-0: Y[2:0] - 0x0 *
*/ * 7:0 0
* 6:1 1
* 2-0: Y[2:0] - 0x0
*/
write_reg(par, 0x40);
} }
static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment