Commit 441be56f authored by Christian Gromm's avatar Christian Gromm Committed by Greg Kroah-Hartman

staging: most: usb: use EINVAL error code

This patch replaces the error code EIO with EINVAL, when there is no IO
happening.
Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Link: https://lore.kernel.org/r/1588672829-28883-3-git-send-email-christian.gromm@microchip.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3e8621ab
...@@ -274,13 +274,13 @@ static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo) ...@@ -274,13 +274,13 @@ static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
unsigned int j, num_frames; unsigned int j, num_frames;
if (!frame_size) if (!frame_size)
return -EIO; return -EINVAL;
num_frames = mbo->buffer_length / frame_size; num_frames = mbo->buffer_length / frame_size;
if (num_frames < 1) { if (num_frames < 1) {
dev_err(&mdev->usb_device->dev, dev_err(&mdev->usb_device->dev,
"Missed minimal transfer unit.\n"); "Missed minimal transfer unit.\n");
return -EIO; return -EINVAL;
} }
for (j = num_frames - 1; j > 0; j--) for (j = num_frames - 1; j > 0; j--)
...@@ -308,7 +308,7 @@ static int hdm_remove_padding(struct most_dev *mdev, int channel, ...@@ -308,7 +308,7 @@ static int hdm_remove_padding(struct most_dev *mdev, int channel,
unsigned int j, num_frames; unsigned int j, num_frames;
if (!frame_size) if (!frame_size)
return -EIO; return -EINVAL;
num_frames = mbo->processed_length / USB_MTU; num_frames = mbo->processed_length / USB_MTU;
for (j = 1; j < num_frames; j++) for (j = 1; j < num_frames; j++)
...@@ -556,7 +556,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel, ...@@ -556,7 +556,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel,
void *virt_address; void *virt_address;
if (unlikely(!mbo)) if (unlikely(!mbo))
return -EIO; return -EINVAL;
if (unlikely(iface->num_channels <= channel || channel < 0)) if (unlikely(iface->num_channels <= channel || channel < 0))
return -ECHRNG; return -ECHRNG;
...@@ -577,7 +577,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel, ...@@ -577,7 +577,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel,
if ((conf->direction & MOST_CH_TX) && mdev->padding_active[channel] && if ((conf->direction & MOST_CH_TX) && mdev->padding_active[channel] &&
hdm_add_padding(mdev, channel, mbo)) { hdm_add_padding(mdev, channel, mbo)) {
retval = -EIO; retval = -EINVAL;
goto err_free_urb; goto err_free_urb;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment