Commit 45a5b3a1 authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (nct6775) Check array index when accessing temp_offset

smatch complains about a potential out-of-bounds access to the
temp_offset array. That doesn't happen in practice, but it doesn't
hurt to add an explicit check either. This prevents potential problems
in the future (for example if the number of 'fixed' temperature
sensors is increased to add support for another chip).
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent e8ab508c
...@@ -1457,7 +1457,8 @@ static struct nct6775_data *nct6775_update_device(struct device *dev) ...@@ -1457,7 +1457,8 @@ static struct nct6775_data *nct6775_update_device(struct device *dev)
= nct6775_read_temp(data, = nct6775_read_temp(data,
data->reg_temp[j][i]); data->reg_temp[j][i]);
} }
if (!(data->have_temp_fixed & (1 << i))) if (i >= NUM_TEMP_FIXED ||
!(data->have_temp_fixed & (1 << i)))
continue; continue;
data->temp_offset[i] data->temp_offset[i]
= nct6775_read_value(data, data->REG_TEMP_OFFSET[i]); = nct6775_read_value(data, data->REG_TEMP_OFFSET[i]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment