Commit 462a6dac authored by Sean Young's avatar Sean Young Committed by Jiri Slaby

dib0700: fix nec repeat handling

commit ba13e98f upstream.

When receiving a nec repeat, ensure the correct scancode is repeated
rather than a random value from the stack.  This removes the need for
the bogus uninitialized_var() and also fixes the warnings:

    drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’:
    drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function

[sean addon: So after writing the patch and submitting it, I've bought the
             hardware on ebay. Without this patch you get random scancodes
             on nec repeats, which the patch indeed fixes.]
Signed-off-by: default avatarSean Young <sean@mess.org>
Tested-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 3b2b619b
...@@ -674,7 +674,7 @@ static void dib0700_rc_urb_completion(struct urb *purb) ...@@ -674,7 +674,7 @@ static void dib0700_rc_urb_completion(struct urb *purb)
{ {
struct dvb_usb_device *d = purb->context; struct dvb_usb_device *d = purb->context;
struct dib0700_rc_response *poll_reply; struct dib0700_rc_response *poll_reply;
u32 uninitialized_var(keycode); u32 keycode;
u8 toggle; u8 toggle;
deb_info("%s()\n", __func__); deb_info("%s()\n", __func__);
...@@ -713,7 +713,8 @@ static void dib0700_rc_urb_completion(struct urb *purb) ...@@ -713,7 +713,8 @@ static void dib0700_rc_urb_completion(struct urb *purb)
if ((poll_reply->system == 0x00) && (poll_reply->data == 0x00) if ((poll_reply->system == 0x00) && (poll_reply->data == 0x00)
&& (poll_reply->not_data == 0xff)) { && (poll_reply->not_data == 0xff)) {
poll_reply->data_state = 2; poll_reply->data_state = 2;
break; rc_repeat(d->rc_dev);
goto resubmit;
} }
if ((poll_reply->system ^ poll_reply->not_system) != 0xff) { if ((poll_reply->system ^ poll_reply->not_system) != 0xff) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment