Commit 471b095d authored by Kees Cook's avatar Kees Cook Committed by Greg Kroah-Hartman

firmware_class: make sure fw requests contain a name

An empty firmware request name will trigger warnings when building
device names. Make sure this is caught earlier and rejected.

The warning was visible via the test_firmware.ko module interface:

echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request
Reported-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Tested-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 41575335
...@@ -1105,6 +1105,9 @@ _request_firmware(const struct firmware **firmware_p, const char *name, ...@@ -1105,6 +1105,9 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
if (!firmware_p) if (!firmware_p)
return -EINVAL; return -EINVAL;
if (!name || name[0] == '\0')
return -EINVAL;
ret = _request_firmware_prepare(&fw, name, device); ret = _request_firmware_prepare(&fw, name, device);
if (ret <= 0) /* error or already assigned */ if (ret <= 0) /* error or already assigned */
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment