Commit 47742bde authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen

scsi: scsi_debug: Fix an error handling bug in sdeb_zbc_model_str()

This test is checking the wrong variable.  It should be testing "res".
The "sdeb_zbc_model" variable is an enum (unsigned in this situation)
and we never assign negative values to it.

[mkp: fixed commit desc issue reported by Doug]

Link: https://lore.kernel.org/r/20200509100408.GA5555@mwanda
Fixes: 9267e0eb ("scsi: scsi_debug: Add ZBC module parameter")
Acked-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d0dff2ac
...@@ -6460,7 +6460,7 @@ static int sdeb_zbc_model_str(const char *cp) ...@@ -6460,7 +6460,7 @@ static int sdeb_zbc_model_str(const char *cp)
res = sysfs_match_string(zbc_model_strs_b, cp); res = sysfs_match_string(zbc_model_strs_b, cp);
if (res < 0) { if (res < 0) {
res = sysfs_match_string(zbc_model_strs_c, cp); res = sysfs_match_string(zbc_model_strs_c, cp);
if (sdeb_zbc_model < 0) if (res < 0)
return -EINVAL; return -EINVAL;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment