Commit 479e37f8 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

[PATCH] PCI: remove usage of pci_for_each_dev() in arch/i386/pci/irq.c

parent 0b29fac8
...@@ -573,7 +573,7 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign) ...@@ -573,7 +573,7 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign)
int irq = 0; int irq = 0;
u32 mask; u32 mask;
struct irq_router *r = pirq_router; struct irq_router *r = pirq_router;
struct pci_dev *dev2; struct pci_dev *dev2 = NULL;
char *msg = NULL; char *msg = NULL;
/* Find IRQ pin */ /* Find IRQ pin */
...@@ -665,7 +665,7 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign) ...@@ -665,7 +665,7 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign)
printk(KERN_INFO "PCI: %s IRQ %d for device %s\n", msg, irq, dev->slot_name); printk(KERN_INFO "PCI: %s IRQ %d for device %s\n", msg, irq, dev->slot_name);
/* Update IRQ for all devices with the same pirq value */ /* Update IRQ for all devices with the same pirq value */
pci_for_each_dev(dev2) { while ((dev2 = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev2)) != NULL) {
pci_read_config_byte(dev2, PCI_INTERRUPT_PIN, &pin); pci_read_config_byte(dev2, PCI_INTERRUPT_PIN, &pin);
if (!pin) if (!pin)
continue; continue;
...@@ -693,11 +693,11 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign) ...@@ -693,11 +693,11 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign)
static void __init pcibios_fixup_irqs(void) static void __init pcibios_fixup_irqs(void)
{ {
struct pci_dev *dev; struct pci_dev *dev = NULL;
u8 pin; u8 pin;
DBG("PCI: IRQ fixup\n"); DBG("PCI: IRQ fixup\n");
pci_for_each_dev(dev) { while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
/* /*
* If the BIOS has set an out of range IRQ number, just ignore it. * If the BIOS has set an out of range IRQ number, just ignore it.
* Also keep track of which IRQ's are already in use. * Also keep track of which IRQ's are already in use.
...@@ -712,7 +712,8 @@ static void __init pcibios_fixup_irqs(void) ...@@ -712,7 +712,8 @@ static void __init pcibios_fixup_irqs(void)
pirq_penalty[dev->irq]++; pirq_penalty[dev->irq]++;
} }
pci_for_each_dev(dev) { dev = NULL;
while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin); pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
#ifdef CONFIG_X86_IO_APIC #ifdef CONFIG_X86_IO_APIC
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment