Commit 47ac56db authored by Mike Snitzer's avatar Mike Snitzer Committed by James Bottomley

[SCSI] scsi_error: classify some ILLEGAL_REQUEST sense as a permanent TARGET_ERROR

Permanent target failures are non-retryable and should be classified as
TARGET_ERROR; otherwise dm-multipath will retry an IO request that will
always fail at the target.

A SCSI command that fails with ILLEGAL_REQUEST sense and Additional
sense 0x20, 0x21, 0x24 or 0x26 represents a permanent TARGET_ERROR.
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 89730393
...@@ -366,6 +366,14 @@ static int scsi_check_sense(struct scsi_cmnd *scmd) ...@@ -366,6 +366,14 @@ static int scsi_check_sense(struct scsi_cmnd *scmd)
return TARGET_ERROR; return TARGET_ERROR;
case ILLEGAL_REQUEST: case ILLEGAL_REQUEST:
if (sshdr.asc == 0x20 || /* Invalid command operation code */
sshdr.asc == 0x21 || /* Logical block address out of range */
sshdr.asc == 0x24 || /* Invalid field in cdb */
sshdr.asc == 0x26) { /* Parameter value invalid */
return TARGET_ERROR;
}
return SUCCESS;
default: default:
return SUCCESS; return SUCCESS;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment