Commit 47ae562e authored by Jan Kara's avatar Jan Kara Committed by Ben Hutchings

vfs: Avoid softlockups with sendfile(2)

commit c2489e07 upstream.

The following test program from Dmitry can cause softlockups or RCU
stalls as it copies 1GB from tmpfs into eventfd and we don't have any
scheduling point at that path in sendfile(2) implementation:

        int r1 = eventfd(0, 0);
        int r2 = memfd_create("", 0);
        unsigned long n = 1<<30;
        fallocate(r2, 0, 0, n);
        sendfile(r1, r2, 0, n);

Add cond_resched() into __splice_from_pipe() to fix the problem.

CC: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 353f5a95
...@@ -957,6 +957,7 @@ ssize_t __splice_from_pipe(struct pipe_inode_info *pipe, struct splice_desc *sd, ...@@ -957,6 +957,7 @@ ssize_t __splice_from_pipe(struct pipe_inode_info *pipe, struct splice_desc *sd,
splice_from_pipe_begin(sd); splice_from_pipe_begin(sd);
do { do {
cond_resched();
ret = splice_from_pipe_next(pipe, sd); ret = splice_from_pipe_next(pipe, sd);
if (ret > 0) if (ret > 0)
ret = splice_from_pipe_feed(pipe, sd, actor); ret = splice_from_pipe_feed(pipe, sd, actor);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment