Commit 485f107d authored by Cyril Roelandt's avatar Cyril Roelandt Committed by John W. Linville

mwifiex: avoid out of bounds access in mwifiex_get_common_rates.

Check that the array indexes are in-bounds before accessing the rate2 and tmp
arrays.

Found with the following semantic patch:

<smpl>
@@
identifier t;
identifier idx;
expression E;
statement S;
@@
* for (... ; <+... t[idx] ...+> && idx < E ; ...)
S
</smpl>
Signed-off-by: default avatarCyril Roelandt <tipecaml@gmail.com>
Acked-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 44ba9736
...@@ -157,8 +157,8 @@ static int mwifiex_get_common_rates(struct mwifiex_private *priv, u8 *rate1, ...@@ -157,8 +157,8 @@ static int mwifiex_get_common_rates(struct mwifiex_private *priv, u8 *rate1,
memset(rate1, 0, rate1_size); memset(rate1, 0, rate1_size);
for (i = 0; rate2[i] && i < rate2_size; i++) { for (i = 0; i < rate2_size && rate2[i]; i++) {
for (j = 0; tmp[j] && j < rate1_size; j++) { for (j = 0; j < rate1_size && tmp[j]; j++) {
/* Check common rate, excluding the bit for /* Check common rate, excluding the bit for
basic rate */ basic rate */
if ((rate2[i] & 0x7F) == (tmp[j] & 0x7F)) { if ((rate2[i] & 0x7F) == (tmp[j] & 0x7F)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment