Commit 4927f1fc authored by Jack Wang's avatar Jack Wang Committed by Martin K. Petersen

isci: remove SCSI host before detaching from SAS transport

commit cff549e4 ("scsi: proper state checking and module refcount
handling in scsi_device_get") , the reference count of scsi device was
changed, which could lead to when rmmod with at least on drive attached,
SCSI error handle will run into infinite loop, and lockup the system.

Fix it by remove scsi host first, this way scsi core will not send
commands down after detaching SAS transport.

This is a follow up fix for Benjamin's fix for pm80xx.

See also:
http://www.spinics.net/lists/linux-scsi/msg90088.htmlSigned-off-by: default avatarJack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ce664fb5
...@@ -272,11 +272,11 @@ static void isci_unregister(struct isci_host *isci_host) ...@@ -272,11 +272,11 @@ static void isci_unregister(struct isci_host *isci_host)
if (!isci_host) if (!isci_host)
return; return;
shost = to_shost(isci_host);
scsi_remove_host(shost);
sas_unregister_ha(&isci_host->sas_ha); sas_unregister_ha(&isci_host->sas_ha);
shost = to_shost(isci_host);
sas_remove_host(shost); sas_remove_host(shost);
scsi_remove_host(shost);
scsi_host_put(shost); scsi_host_put(shost);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment