Commit 4942093e authored by Linus Torvalds's avatar Linus Torvalds

Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6:
  USB: revert portions of "UNUSUAL_DEV: Sync up some reported devices from Ubuntu"
  usb: Remove broken optimisation in OHCI IRQ handler
  USB: at91_udc: correct hanging while disconnecting usb cable
  USB: use IRQF_DISABLED for HCD interrupt handlers
  USB: fix locking loop by avoiding flush_scheduled_work
  usb.h: fix kernel-doc warning
  USB: option: Bind to the correct interface of the Huawei E220
  USB: cp2101: new device id
  usb-storage: Fix devices that cannot handle 32k transfers
  USB: sierra: fix product id
parents 07232b97 e70e7690
...@@ -125,7 +125,7 @@ int usb_hcd_pci_probe (struct pci_dev *dev, const struct pci_device_id *id) ...@@ -125,7 +125,7 @@ int usb_hcd_pci_probe (struct pci_dev *dev, const struct pci_device_id *id)
pci_set_master (dev); pci_set_master (dev);
retval = usb_add_hcd (hcd, dev->irq, IRQF_SHARED); retval = usb_add_hcd(hcd, dev->irq, IRQF_DISABLED | IRQF_SHARED);
if (retval != 0) if (retval != 0)
goto err4; goto err4;
return retval; return retval;
......
...@@ -522,9 +522,9 @@ static void hub_quiesce(struct usb_hub *hub) ...@@ -522,9 +522,9 @@ static void hub_quiesce(struct usb_hub *hub)
/* (blocking) stop khubd and related activity */ /* (blocking) stop khubd and related activity */
usb_kill_urb(hub->urb); usb_kill_urb(hub->urb);
if (hub->has_indicators) if (hub->has_indicators)
cancel_delayed_work(&hub->leds); cancel_delayed_work_sync(&hub->leds);
if (hub->has_indicators || hub->tt.hub) if (hub->tt.hub)
flush_scheduled_work(); cancel_work_sync(&hub->tt.kevent);
} }
static void hub_activate(struct usb_hub *hub) static void hub_activate(struct usb_hub *hub)
......
...@@ -887,6 +887,7 @@ static void pullup(struct at91_udc *udc, int is_on) ...@@ -887,6 +887,7 @@ static void pullup(struct at91_udc *udc, int is_on)
if (is_on) { if (is_on) {
clk_on(udc); clk_on(udc);
at91_udp_write(udc, AT91_UDP_ICR, AT91_UDP_RXRSM);
at91_udp_write(udc, AT91_UDP_TXVC, 0); at91_udp_write(udc, AT91_UDP_TXVC, 0);
if (cpu_is_at91rm9200()) if (cpu_is_at91rm9200())
at91_set_gpio_value(udc->board.pullup_pin, 1); at91_set_gpio_value(udc->board.pullup_pin, 1);
...@@ -904,6 +905,7 @@ static void pullup(struct at91_udc *udc, int is_on) ...@@ -904,6 +905,7 @@ static void pullup(struct at91_udc *udc, int is_on)
} }
} else { } else {
stop_activity(udc); stop_activity(udc);
at91_udp_write(udc, AT91_UDP_IDR, AT91_UDP_RXRSM);
at91_udp_write(udc, AT91_UDP_TXVC, AT91_UDP_TXVC_TXVDIS); at91_udp_write(udc, AT91_UDP_TXVC, AT91_UDP_TXVC_TXVDIS);
if (cpu_is_at91rm9200()) if (cpu_is_at91rm9200())
at91_set_gpio_value(udc->board.pullup_pin, 0); at91_set_gpio_value(udc->board.pullup_pin, 0);
......
...@@ -122,7 +122,7 @@ int usb_hcd_fsl_probe(const struct hc_driver *driver, ...@@ -122,7 +122,7 @@ int usb_hcd_fsl_probe(const struct hc_driver *driver,
temp = in_le32(hcd->regs + 0x1a8); temp = in_le32(hcd->regs + 0x1a8);
out_le32(hcd->regs + 0x1a8, temp | 0x3); out_le32(hcd->regs + 0x1a8, temp | 0x3);
retval = usb_add_hcd(hcd, irq, IRQF_SHARED); retval = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED);
if (retval != 0) if (retval != 0)
goto err4; goto err4;
return retval; return retval;
......
...@@ -732,24 +732,27 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd) ...@@ -732,24 +732,27 @@ static irqreturn_t ohci_irq (struct usb_hcd *hcd)
struct ohci_regs __iomem *regs = ohci->regs; struct ohci_regs __iomem *regs = ohci->regs;
int ints; int ints;
/* we can eliminate a (slow) ohci_readl() /* Read interrupt status (and flush pending writes). We ignore the
* if _only_ WDH caused this irq * optimization of checking the LSB of hcca->done_head; it doesn't
* work on all systems (edge triggering for OHCI can be a factor).
*/ */
if ((ohci->hcca->done_head != 0) ints = ohci_readl(ohci, &regs->intrstatus);
&& ! (hc32_to_cpup (ohci, &ohci->hcca->done_head)
& 0x01)) {
ints = OHCI_INTR_WDH;
/* cardbus/... hardware gone before remove() */ /* Check for an all 1's result which is a typical consequence
} else if ((ints = ohci_readl (ohci, &regs->intrstatus)) == ~(u32)0) { * of dead, unclocked, or unplugged (CardBus...) devices
*/
if (ints == ~(u32)0) {
disable (ohci); disable (ohci);
ohci_dbg (ohci, "device removed!\n"); ohci_dbg (ohci, "device removed!\n");
return IRQ_HANDLED; return IRQ_HANDLED;
}
/* We only care about interrupts that are enabled */
ints &= ohci_readl(ohci, &regs->intrenable);
/* interrupt for some other device? */ /* interrupt for some other device? */
} else if ((ints &= ohci_readl (ohci, &regs->intrenable)) == 0) { if (ints == 0)
return IRQ_NOTMINE; return IRQ_NOTMINE;
}
if (ints & OHCI_INTR_UE) { if (ints & OHCI_INTR_UE) {
// e.g. due to PCI Master/Target Abort // e.g. due to PCI Master/Target Abort
......
...@@ -142,7 +142,7 @@ ohci_hcd_ppc_of_probe(struct of_device *op, const struct of_device_id *match) ...@@ -142,7 +142,7 @@ ohci_hcd_ppc_of_probe(struct of_device *op, const struct of_device_id *match)
ohci_hcd_init(ohci); ohci_hcd_init(ohci);
rv = usb_add_hcd(hcd, irq, 0); rv = usb_add_hcd(hcd, irq, IRQF_DISABLED);
if (rv == 0) if (rv == 0)
return 0; return 0;
......
...@@ -160,7 +160,7 @@ static int ssb_ohci_attach(struct ssb_device *dev) ...@@ -160,7 +160,7 @@ static int ssb_ohci_attach(struct ssb_device *dev)
hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len); hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len);
if (!hcd->regs) if (!hcd->regs)
goto err_put_hcd; goto err_put_hcd;
err = usb_add_hcd(hcd, dev->irq, IRQF_SHARED); err = usb_add_hcd(hcd, dev->irq, IRQF_DISABLED | IRQF_SHARED);
if (err) if (err)
goto err_iounmap; goto err_iounmap;
......
...@@ -2197,7 +2197,7 @@ static int __init r8a66597_probe(struct platform_device *pdev) ...@@ -2197,7 +2197,7 @@ static int __init r8a66597_probe(struct platform_device *pdev)
INIT_LIST_HEAD(&r8a66597->child_device); INIT_LIST_HEAD(&r8a66597->child_device);
hcd->rsrc_start = res->start; hcd->rsrc_start = res->start;
ret = usb_add_hcd(hcd, irq, 0); ret = usb_add_hcd(hcd, irq, IRQF_DISABLED);
if (ret != 0) { if (ret != 0) {
err("Failed to add hcd"); err("Failed to add hcd");
goto clean_up; goto clean_up;
......
...@@ -378,7 +378,6 @@ static irqreturn_t uhci_irq(struct usb_hcd *hcd) ...@@ -378,7 +378,6 @@ static irqreturn_t uhci_irq(struct usb_hcd *hcd)
{ {
struct uhci_hcd *uhci = hcd_to_uhci(hcd); struct uhci_hcd *uhci = hcd_to_uhci(hcd);
unsigned short status; unsigned short status;
unsigned long flags;
/* /*
* Read the interrupt status, and write it back to clear the * Read the interrupt status, and write it back to clear the
...@@ -398,7 +397,7 @@ static irqreturn_t uhci_irq(struct usb_hcd *hcd) ...@@ -398,7 +397,7 @@ static irqreturn_t uhci_irq(struct usb_hcd *hcd)
dev_err(uhci_dev(uhci), "host controller process " dev_err(uhci_dev(uhci), "host controller process "
"error, something bad happened!\n"); "error, something bad happened!\n");
if (status & USBSTS_HCH) { if (status & USBSTS_HCH) {
spin_lock_irqsave(&uhci->lock, flags); spin_lock(&uhci->lock);
if (uhci->rh_state >= UHCI_RH_RUNNING) { if (uhci->rh_state >= UHCI_RH_RUNNING) {
dev_err(uhci_dev(uhci), dev_err(uhci_dev(uhci),
"host controller halted, " "host controller halted, "
...@@ -415,16 +414,16 @@ static irqreturn_t uhci_irq(struct usb_hcd *hcd) ...@@ -415,16 +414,16 @@ static irqreturn_t uhci_irq(struct usb_hcd *hcd)
* pending unlinks */ * pending unlinks */
mod_timer(&hcd->rh_timer, jiffies); mod_timer(&hcd->rh_timer, jiffies);
} }
spin_unlock_irqrestore(&uhci->lock, flags); spin_unlock(&uhci->lock);
} }
} }
if (status & USBSTS_RD) if (status & USBSTS_RD)
usb_hcd_poll_rh_status(hcd); usb_hcd_poll_rh_status(hcd);
else { else {
spin_lock_irqsave(&uhci->lock, flags); spin_lock(&uhci->lock);
uhci_scan_schedule(uhci); uhci_scan_schedule(uhci);
spin_unlock_irqrestore(&uhci->lock, flags); spin_unlock(&uhci->lock);
} }
return IRQ_HANDLED; return IRQ_HANDLED;
......
...@@ -71,6 +71,7 @@ static struct usb_device_id id_table [] = { ...@@ -71,6 +71,7 @@ static struct usb_device_id id_table [] = {
{ USB_DEVICE(0x10C4, 0x815E) }, /* Helicomm IP-Link 1220-DVM */ { USB_DEVICE(0x10C4, 0x815E) }, /* Helicomm IP-Link 1220-DVM */
{ USB_DEVICE(0x10C4, 0x81C8) }, /* Lipowsky Industrie Elektronik GmbH, Baby-JTAG */ { USB_DEVICE(0x10C4, 0x81C8) }, /* Lipowsky Industrie Elektronik GmbH, Baby-JTAG */
{ USB_DEVICE(0x10C4, 0x81E2) }, /* Lipowsky Industrie Elektronik GmbH, Baby-LIN */ { USB_DEVICE(0x10C4, 0x81E2) }, /* Lipowsky Industrie Elektronik GmbH, Baby-LIN */
{ USB_DEVICE(0x10C4, 0x81E7) }, /* Aerocomm Radio */
{ USB_DEVICE(0x10C4, 0x8218) }, /* Lipowsky Industrie Elektronik GmbH, HARP-1 */ { USB_DEVICE(0x10C4, 0x8218) }, /* Lipowsky Industrie Elektronik GmbH, HARP-1 */
{ USB_DEVICE(0x10C4, 0xEA60) }, /* Silicon Labs factory default */ { USB_DEVICE(0x10C4, 0xEA60) }, /* Silicon Labs factory default */
{ USB_DEVICE(0x10C4, 0xEA61) }, /* Silicon Labs factory default */ { USB_DEVICE(0x10C4, 0xEA61) }, /* Silicon Labs factory default */
...@@ -98,8 +99,8 @@ static struct usb_serial_driver cp2101_device = { ...@@ -98,8 +99,8 @@ static struct usb_serial_driver cp2101_device = {
.usb_driver = &cp2101_driver, .usb_driver = &cp2101_driver,
.id_table = id_table, .id_table = id_table,
.num_interrupt_in = 0, .num_interrupt_in = 0,
.num_bulk_in = 0, .num_bulk_in = NUM_DONT_CARE,
.num_bulk_out = 0, .num_bulk_out = NUM_DONT_CARE,
.num_ports = 1, .num_ports = 1,
.open = cp2101_open, .open = cp2101_open,
.close = cp2101_close, .close = cp2101_close,
......
...@@ -158,8 +158,8 @@ static struct usb_device_id option_ids[] = { ...@@ -158,8 +158,8 @@ static struct usb_device_id option_ids[] = {
{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_MODEM) }, { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_MODEM) },
{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_NETWORK) }, { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_NETWORK) },
{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) }, { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) },
{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) }, { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) },
{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) }, { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS, 0xff, 0xff, 0xff) },
{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1100) }, /* Novatel Merlin XS620/S640 */ { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1100) }, /* Novatel Merlin XS620/S640 */
{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1110) }, /* Novatel Merlin S620 */ { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1110) }, /* Novatel Merlin S620 */
{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1120) }, /* Novatel Merlin EX720 */ { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1120) }, /* Novatel Merlin EX720 */
......
...@@ -100,6 +100,7 @@ static struct usb_device_id id_table [] = { ...@@ -100,6 +100,7 @@ static struct usb_device_id id_table [] = {
{ USB_DEVICE(0x1199, 0x0218) }, /* Sierra Wireless MC5720 */ { USB_DEVICE(0x1199, 0x0218) }, /* Sierra Wireless MC5720 */
{ USB_DEVICE(0x0f30, 0x1b1d) }, /* Sierra Wireless MC5720 */ { USB_DEVICE(0x0f30, 0x1b1d) }, /* Sierra Wireless MC5720 */
{ USB_DEVICE(0x1199, 0x0020) }, /* Sierra Wireless MC5725 */ { USB_DEVICE(0x1199, 0x0020) }, /* Sierra Wireless MC5725 */
{ USB_DEVICE(0x1199, 0x0220) }, /* Sierra Wireless MC5725 */
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */ { USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */ { USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U */ { USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U */
...@@ -137,7 +138,6 @@ static struct usb_device_id id_table_3port [] = { ...@@ -137,7 +138,6 @@ static struct usb_device_id id_table_3port [] = {
{ USB_DEVICE(0x1199, 0x0218) }, /* Sierra Wireless MC5720 */ { USB_DEVICE(0x1199, 0x0218) }, /* Sierra Wireless MC5720 */
{ USB_DEVICE(0x1199, 0x0020) }, /* Sierra Wireless MC5725 */ { USB_DEVICE(0x1199, 0x0020) }, /* Sierra Wireless MC5725 */
{ USB_DEVICE(0x1199, 0x0220) }, /* Sierra Wireless MC5725 */ { USB_DEVICE(0x1199, 0x0220) }, /* Sierra Wireless MC5725 */
{ USB_DEVICE(0x1199, 0x0220) }, /* Sierra Wireless MC5725 */
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */ { USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */ { USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U*/ { USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U*/
......
...@@ -114,9 +114,15 @@ static int slave_configure(struct scsi_device *sdev) ...@@ -114,9 +114,15 @@ static int slave_configure(struct scsi_device *sdev)
* while others have trouble with more than 64K. At this time we * while others have trouble with more than 64K. At this time we
* are limiting both to 32K (64 sectores). * are limiting both to 32K (64 sectores).
*/ */
if ((us->flags & US_FL_MAX_SECTORS_64) && if (us->flags & (US_FL_MAX_SECTORS_64 | US_FL_MAX_SECTORS_MIN)) {
sdev->request_queue->max_sectors > 64) unsigned int max_sectors = 64;
blk_queue_max_sectors(sdev->request_queue, 64);
if (us->flags & US_FL_MAX_SECTORS_MIN)
max_sectors = PAGE_CACHE_SIZE >> 9;
if (sdev->request_queue->max_sectors > max_sectors)
blk_queue_max_sectors(sdev->request_queue,
max_sectors);
}
/* We can't put these settings in slave_alloc() because that gets /* We can't put these settings in slave_alloc() because that gets
* called before the device type is known. Consequently these * called before the device type is known. Consequently these
......
...@@ -376,6 +376,13 @@ UNUSUAL_DEV( 0x04b0, 0x0417, 0x0100, 0x0100, ...@@ -376,6 +376,13 @@ UNUSUAL_DEV( 0x04b0, 0x0417, 0x0100, 0x0100,
US_SC_DEVICE, US_PR_DEVICE, NULL, US_SC_DEVICE, US_PR_DEVICE, NULL,
US_FL_FIX_CAPACITY), US_FL_FIX_CAPACITY),
/* Reported by Doug Maxey (dwm@austin.ibm.com) */
UNUSUAL_DEV( 0x04b3, 0x4001, 0x0110, 0x0110,
"IBM",
"IBM RSA2",
US_SC_DEVICE, US_PR_CB, NULL,
US_FL_MAX_SECTORS_MIN),
/* BENQ DC5330 /* BENQ DC5330
* Reported by Manuel Fombuena <mfombuena@ya.com> and * Reported by Manuel Fombuena <mfombuena@ya.com> and
* Frank Copeland <fjc@thingy.apana.org.au> */ * Frank Copeland <fjc@thingy.apana.org.au> */
...@@ -1258,14 +1265,6 @@ UNUSUAL_DEV( 0x0ace, 0x20ff, 0x0101, 0x0101, ...@@ -1258,14 +1265,6 @@ UNUSUAL_DEV( 0x0ace, 0x20ff, 0x0101, 0x0101,
US_SC_DEVICE, US_PR_DEVICE, NULL, US_SC_DEVICE, US_PR_DEVICE, NULL,
US_FL_IGNORE_DEVICE ), US_FL_IGNORE_DEVICE ),
/* SanDisk that has a second LUN for a driver ISO, reported by
* Ben Collins <bcollins@ubuntu.com> */
UNUSUAL_DEV( 0x0781, 0x5406, 0x0000, 0xffff,
"SanDisk",
"U3 Cruzer Micro driver ISO",
US_SC_DEVICE, US_PR_DEVICE, NULL,
US_FL_SINGLE_LUN ),
#ifdef CONFIG_USB_STORAGE_ISD200 #ifdef CONFIG_USB_STORAGE_ISD200
UNUSUAL_DEV( 0x0bf6, 0xa001, 0x0100, 0x0110, UNUSUAL_DEV( 0x0bf6, 0xa001, 0x0100, 0x0110,
"ATI", "ATI",
......
...@@ -107,6 +107,7 @@ enum usb_interface_condition { ...@@ -107,6 +107,7 @@ enum usb_interface_condition {
* @condition: binding state of the interface: not bound, binding * @condition: binding state of the interface: not bound, binding
* (in probe()), bound to a driver, or unbinding (in disconnect()) * (in probe()), bound to a driver, or unbinding (in disconnect())
* @is_active: flag set when the interface is bound and not suspended. * @is_active: flag set when the interface is bound and not suspended.
* @sysfs_files_created: sysfs attributes exist
* @needs_remote_wakeup: flag set when the driver requires remote-wakeup * @needs_remote_wakeup: flag set when the driver requires remote-wakeup
* capability during autosuspend. * capability during autosuspend.
* @dev: driver model's view of this device * @dev: driver model's view of this device
......
...@@ -48,7 +48,10 @@ ...@@ -48,7 +48,10 @@
US_FLAG(IGNORE_DEVICE, 0x00000800) \ US_FLAG(IGNORE_DEVICE, 0x00000800) \
/* Don't claim device */ \ /* Don't claim device */ \
US_FLAG(CAPACITY_HEURISTICS, 0x00001000) \ US_FLAG(CAPACITY_HEURISTICS, 0x00001000) \
/* sometimes sizes is too big */ /* sometimes sizes is too big */ \
US_FLAG(MAX_SECTORS_MIN,0x00002000) \
/* Sets max_sectors to arch min */
#define US_FLAG(name, value) US_FL_##name = value , #define US_FLAG(name, value) US_FL_##name = value ,
enum { US_DO_ALL_FLAGS }; enum { US_DO_ALL_FLAGS };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment