Commit 49769d4d authored by Haibo Chen's avatar Haibo Chen Committed by Ulf Hansson

mmc: sdhci: add spin lock for sdhci_set_default_irqs in sdhci_init

When use one SDIO wifi which enable the runtime PM feature on i.MX6SX,
we meet system hang. This hang happened during the usdhc runtime resume,
in sdhci_init(), when call the sdhci_set_default_irqs. One interrupt
(SDHCI_INT_CARD_INT) triggered just after the host->ier update and before
the write of register SDHCI_SIGNAL_ENABLE. So in sdhci_irq, it will skip
the call of sdio_signal_irq() because current host->ier do not set the
SDHCI_INT_CARD_INT. So this SDIO wifi interrupt always keep triggered,
let the system stuck in irq handle, can't response any other thread.

This patch add spin lock for the sdhci_set_default_irqs to fix this issue.
Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/1586941255-9237-1-git-send-email-haibo.chen@nxp.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 61ab64e2
...@@ -317,6 +317,7 @@ static void sdhci_config_dma(struct sdhci_host *host) ...@@ -317,6 +317,7 @@ static void sdhci_config_dma(struct sdhci_host *host)
static void sdhci_init(struct sdhci_host *host, int soft) static void sdhci_init(struct sdhci_host *host, int soft)
{ {
struct mmc_host *mmc = host->mmc; struct mmc_host *mmc = host->mmc;
unsigned long flags;
if (soft) if (soft)
sdhci_do_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA); sdhci_do_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA);
...@@ -326,7 +327,9 @@ static void sdhci_init(struct sdhci_host *host, int soft) ...@@ -326,7 +327,9 @@ static void sdhci_init(struct sdhci_host *host, int soft)
if (host->v4_mode) if (host->v4_mode)
sdhci_do_enable_v4_mode(host); sdhci_do_enable_v4_mode(host);
spin_lock_irqsave(&host->lock, flags);
sdhci_set_default_irqs(host); sdhci_set_default_irqs(host);
spin_unlock_irqrestore(&host->lock, flags);
host->cqe_on = false; host->cqe_on = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment