Commit 4a3c6433 authored by Alexander Duyck's avatar Alexander Duyck Committed by David S. Miller

igb: don't read eicr when responding to legacy interrupts

The interrupt handler was reading eicr and then doing nothing with the
result.  I have removed the variable and the register read since they
provide no value to the legacy interrupt handler.
Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 28b0759c
...@@ -3519,7 +3519,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data) ...@@ -3519,7 +3519,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data)
} }
/** /**
* igb_intr - Interrupt Handler * igb_intr - Legacy Interrupt Handler
* @irq: interrupt number * @irq: interrupt number
* @data: pointer to a network interface device structure * @data: pointer to a network interface device structure
**/ **/
...@@ -3531,7 +3531,6 @@ static irqreturn_t igb_intr(int irq, void *data) ...@@ -3531,7 +3531,6 @@ static irqreturn_t igb_intr(int irq, void *data)
/* Interrupt Auto-Mask...upon reading ICR, interrupts are masked. No /* Interrupt Auto-Mask...upon reading ICR, interrupts are masked. No
* need for the IMC write */ * need for the IMC write */
u32 icr = rd32(E1000_ICR); u32 icr = rd32(E1000_ICR);
u32 eicr = 0;
if (!icr) if (!icr)
return IRQ_NONE; /* Not our interrupt */ return IRQ_NONE; /* Not our interrupt */
...@@ -3547,8 +3546,6 @@ static irqreturn_t igb_intr(int irq, void *data) ...@@ -3547,8 +3546,6 @@ static irqreturn_t igb_intr(int irq, void *data)
adapter->stats.doosync++; adapter->stats.doosync++;
} }
eicr = rd32(E1000_EICR);
if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) { if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) {
hw->mac.get_link_status = 1; hw->mac.get_link_status = 1;
/* guard against interrupt when we're going down */ /* guard against interrupt when we're going down */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment