Commit 4a4a56b4 authored by Tom Zanussi's avatar Tom Zanussi Committed by Steven Rostedt (VMware)

tracing: Change STR_VAR_MAX_LEN

32 is too small for this value, and anyway it makes more sense to use
MAX_FILTER_STR_VAL, as this is also the value used for variable-length
__strings.

Link: https://lkml.kernel.org/r/6adfd1668ac1fd8670bd58206944a762061a5559.1601848695.git.zanussi@kernel.orgTested-by: default avatarAxel Rasmussen <axelrasmussen@google.com>
Signed-off-by: default avatarTom Zanussi <zanussi@kernel.org>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent fdda88d3
...@@ -1398,6 +1398,8 @@ static int hist_trigger_elt_data_alloc(struct tracing_map_elt *elt) ...@@ -1398,6 +1398,8 @@ static int hist_trigger_elt_data_alloc(struct tracing_map_elt *elt)
n_str = hist_data->n_field_var_str + hist_data->n_save_var_str; n_str = hist_data->n_field_var_str + hist_data->n_save_var_str;
BUILD_BUG_ON(STR_VAR_LEN_MAX & (sizeof(u64) - 1));
size = STR_VAR_LEN_MAX; size = STR_VAR_LEN_MAX;
for (i = 0; i < n_str; i++) { for (i = 0; i < n_str; i++) {
......
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
#define SYNTH_SYSTEM "synthetic" #define SYNTH_SYSTEM "synthetic"
#define SYNTH_FIELDS_MAX 32 #define SYNTH_FIELDS_MAX 32
#define STR_VAR_LEN_MAX 32 /* must be multiple of sizeof(u64) */ #define STR_VAR_LEN_MAX MAX_FILTER_STR_VAL /* must be multiple of sizeof(u64) */
struct synth_field { struct synth_field {
char *type; char *type;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment