Commit 4a7795d3 authored by Yan, Zheng's avatar Yan, Zheng Committed by Al Viro

vfs: fix reference leak in d_prune_aliases()

In "d_prune_alias(): just lock the parent and call __dentry_kill()" the old
dget + d_drop + dput has been replaced with lock_parent + __dentry_kill;
unfortunately, dput() does more than just killing dentry - it also drops the
reference to parent.  New variant leaks that reference and needs dput(parent)
after killing the child off.
Signed-off-by: default avatarYan, Zheng <zyan@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ad0eab92
...@@ -778,6 +778,7 @@ void d_prune_aliases(struct inode *inode) ...@@ -778,6 +778,7 @@ void d_prune_aliases(struct inode *inode)
struct dentry *parent = lock_parent(dentry); struct dentry *parent = lock_parent(dentry);
if (likely(!dentry->d_lockref.count)) { if (likely(!dentry->d_lockref.count)) {
__dentry_kill(dentry); __dentry_kill(dentry);
dput(parent);
goto restart; goto restart;
} }
if (parent) if (parent)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment