Commit 4b48512c authored by Jiri Slaby's avatar Jiri Slaby Committed by Ingo Molnar

stacktrace: Get rid of unneeded '!!' pattern

My commit b0c51f15 ("stacktrace: Don't skip first entry on
noncurrent tasks") adds one or zero to skipnr by "!!(current == tsk)".

But the C99 standard says:

  The == (equal to) and != (not equal to) operators are
  ...
  Each of the operators yields 1 if the specified relation is true and 0
  if it is false.

So there is no need to prepend the above expression by "!!" -- remove it.
Reported-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20191111092647.27419-1-jslaby@suse.czSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 31f4f5b4
...@@ -142,7 +142,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store, ...@@ -142,7 +142,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store,
.store = store, .store = store,
.size = size, .size = size,
/* skip this function if they are tracing us */ /* skip this function if they are tracing us */
.skip = skipnr + !!(current == tsk), .skip = skipnr + (current == tsk),
}; };
if (!try_get_task_stack(tsk)) if (!try_get_task_stack(tsk))
...@@ -300,7 +300,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *task, ...@@ -300,7 +300,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *task,
.entries = store, .entries = store,
.max_entries = size, .max_entries = size,
/* skip this function if they are tracing us */ /* skip this function if they are tracing us */
.skip = skipnr + !!(current == task), .skip = skipnr + (current == task),
}; };
save_stack_trace_tsk(task, &trace); save_stack_trace_tsk(task, &trace);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment