Commit 4c192665 authored by Bryan O'Donoghue's avatar Bryan O'Donoghue Committed by Greg Kroah-Hartman

greybus: loopback: functionally decompose calculation of turn-around times

We have a pattern similar to this over and over again gb->elapsed_nsecs =
timeval_to_ns(&te) - timeval_to_ns(&ts); good software practice dictates we
functionally decompose this. This patch decomposes into
gb_loopback_calc_latency().
Signed-off-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 3f2a809e
...@@ -219,6 +219,16 @@ static struct attribute *loopback_attrs[] = { ...@@ -219,6 +219,16 @@ static struct attribute *loopback_attrs[] = {
}; };
ATTRIBUTE_GROUPS(loopback); ATTRIBUTE_GROUPS(loopback);
static void gb_loopback_calc_latency(struct gb_loopback *gb,
struct timeval *ts, struct timeval *te)
{
u64 t1, t2;
t1 = timeval_to_ns(ts);
t2 = timeval_to_ns(te);
gb->elapsed_nsecs = t2 - t1;
}
static int gb_loopback_sink(struct gb_loopback *gb, u32 len) static int gb_loopback_sink(struct gb_loopback *gb, u32 len)
{ {
struct timeval ts, te; struct timeval ts, te;
...@@ -236,7 +246,7 @@ static int gb_loopback_sink(struct gb_loopback *gb, u32 len) ...@@ -236,7 +246,7 @@ static int gb_loopback_sink(struct gb_loopback *gb, u32 len)
request, len + sizeof(*request), NULL, 0); request, len + sizeof(*request), NULL, 0);
do_gettimeofday(&te); do_gettimeofday(&te);
gb->elapsed_nsecs = timeval_to_ns(&te) - timeval_to_ns(&ts); gb_loopback_calc_latency(gb, &ts, &te);
kfree(request); kfree(request);
return retval; return retval;
...@@ -265,7 +275,7 @@ static int gb_loopback_transfer(struct gb_loopback *gb, u32 len) ...@@ -265,7 +275,7 @@ static int gb_loopback_transfer(struct gb_loopback *gb, u32 len)
request, len + sizeof(*request), request, len + sizeof(*request),
response, len + sizeof(*response)); response, len + sizeof(*response));
do_gettimeofday(&te); do_gettimeofday(&te);
gb->elapsed_nsecs = timeval_to_ns(&te) - timeval_to_ns(&ts); gb_loopback_calc_latency(gb, &ts, &te);
if (retval) if (retval)
goto gb_error; goto gb_error;
...@@ -289,7 +299,7 @@ static int gb_loopback_ping(struct gb_loopback *gb) ...@@ -289,7 +299,7 @@ static int gb_loopback_ping(struct gb_loopback *gb)
retval = gb_operation_sync(gb->connection, GB_LOOPBACK_TYPE_PING, retval = gb_operation_sync(gb->connection, GB_LOOPBACK_TYPE_PING,
NULL, 0, NULL, 0); NULL, 0, NULL, 0);
do_gettimeofday(&te); do_gettimeofday(&te);
gb->elapsed_nsecs = timeval_to_ns(&te) - timeval_to_ns(&ts); gb_loopback_calc_latency(gb, &ts, &te);
return retval; return retval;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment