Commit 4c625a97 authored by Trond Myklebust's avatar Trond Myklebust

SUNRPC: fix a list corruption issue in xprt_release()

We remove the request from the receive list before we call
xprt_wait_on_pinned_rqst(), and so we need to use list_del_init().
Otherwise, we will see list corruption when xprt_complete_rqst()
is called.
Reported-by: default avatarEmre Celebi <emre@primarydata.com>
Fixes: ce7c252a ("SUNRPC: Add a separate spinlock to protect...")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 33d930e5
...@@ -1333,7 +1333,7 @@ void xprt_release(struct rpc_task *task) ...@@ -1333,7 +1333,7 @@ void xprt_release(struct rpc_task *task)
rpc_count_iostats(task, task->tk_client->cl_metrics); rpc_count_iostats(task, task->tk_client->cl_metrics);
spin_lock(&xprt->recv_lock); spin_lock(&xprt->recv_lock);
if (!list_empty(&req->rq_list)) { if (!list_empty(&req->rq_list)) {
list_del(&req->rq_list); list_del_init(&req->rq_list);
xprt_wait_on_pinned_rqst(req); xprt_wait_on_pinned_rqst(req);
} }
spin_unlock(&xprt->recv_lock); spin_unlock(&xprt->recv_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment