Commit 4ca5ded2 authored by Linus Torvalds's avatar Linus Torvalds

Merge branch 'x86-fixes-for-linus' of...

Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

* 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  x86/agp: Fix agp_amd64_init regression
  x86: Add quirk for Intel DG45FC board to avoid low memory corruption
  x86: Add Dell OptiPlex 760 reboot quirk
  x86, UV: Fix RTC latency bug by reading replicated cachelines
  oprofile/x86: add Xeon 7500 series support
  oprofile/x86: fix crash when profiling more than 28 events
  lib/dma-debug.c: mark file-local struct symbol static.
  x86/amd-iommu: Fix deassignment of a device from the pt_domain
  x86/amd-iommu: Fix IOMMU-API initialization for iommu=pt
  x86/amd-iommu: Fix NULL pointer dereference in __detach_device()
  x86/amd-iommu: Fix possible integer overflow
parents ed23690d 61684cea
...@@ -31,6 +31,7 @@ extern void amd_iommu_reset_cmd_buffer(struct amd_iommu *iommu); ...@@ -31,6 +31,7 @@ extern void amd_iommu_reset_cmd_buffer(struct amd_iommu *iommu);
extern int amd_iommu_init_devices(void); extern int amd_iommu_init_devices(void);
extern void amd_iommu_uninit_devices(void); extern void amd_iommu_uninit_devices(void);
extern void amd_iommu_init_notifier(void); extern void amd_iommu_init_notifier(void);
extern void amd_iommu_init_api(void);
#ifndef CONFIG_AMD_IOMMU_STATS #ifndef CONFIG_AMD_IOMMU_STATS
static inline void amd_iommu_stats_init(void) { } static inline void amd_iommu_stats_init(void) { }
......
...@@ -980,7 +980,7 @@ static int alloc_new_range(struct dma_ops_domain *dma_dom, ...@@ -980,7 +980,7 @@ static int alloc_new_range(struct dma_ops_domain *dma_dom,
{ {
int index = dma_dom->aperture_size >> APERTURE_RANGE_SHIFT; int index = dma_dom->aperture_size >> APERTURE_RANGE_SHIFT;
struct amd_iommu *iommu; struct amd_iommu *iommu;
int i; unsigned long i;
#ifdef CONFIG_IOMMU_STRESS #ifdef CONFIG_IOMMU_STRESS
populate = false; populate = false;
...@@ -1489,11 +1489,14 @@ static void __detach_device(struct device *dev) ...@@ -1489,11 +1489,14 @@ static void __detach_device(struct device *dev)
{ {
struct iommu_dev_data *dev_data = get_dev_data(dev); struct iommu_dev_data *dev_data = get_dev_data(dev);
struct iommu_dev_data *alias_data; struct iommu_dev_data *alias_data;
struct protection_domain *domain;
unsigned long flags; unsigned long flags;
BUG_ON(!dev_data->domain); BUG_ON(!dev_data->domain);
spin_lock_irqsave(&dev_data->domain->lock, flags); domain = dev_data->domain;
spin_lock_irqsave(&domain->lock, flags);
if (dev_data->alias != dev) { if (dev_data->alias != dev) {
alias_data = get_dev_data(dev_data->alias); alias_data = get_dev_data(dev_data->alias);
...@@ -1504,13 +1507,15 @@ static void __detach_device(struct device *dev) ...@@ -1504,13 +1507,15 @@ static void __detach_device(struct device *dev)
if (atomic_dec_and_test(&dev_data->bind)) if (atomic_dec_and_test(&dev_data->bind))
do_detach(dev); do_detach(dev);
spin_unlock_irqrestore(&dev_data->domain->lock, flags); spin_unlock_irqrestore(&domain->lock, flags);
/* /*
* If we run in passthrough mode the device must be assigned to the * If we run in passthrough mode the device must be assigned to the
* passthrough domain if it is detached from any other domain * passthrough domain if it is detached from any other domain.
* Make sure we can deassign from the pt_domain itself.
*/ */
if (iommu_pass_through && dev_data->domain == NULL) if (iommu_pass_through &&
(dev_data->domain == NULL && domain != pt_domain))
__attach_device(dev, pt_domain); __attach_device(dev, pt_domain);
} }
...@@ -2218,6 +2223,12 @@ static struct dma_map_ops amd_iommu_dma_ops = { ...@@ -2218,6 +2223,12 @@ static struct dma_map_ops amd_iommu_dma_ops = {
/* /*
* The function which clues the AMD IOMMU driver into dma_ops. * The function which clues the AMD IOMMU driver into dma_ops.
*/ */
void __init amd_iommu_init_api(void)
{
register_iommu(&amd_iommu_ops);
}
int __init amd_iommu_init_dma_ops(void) int __init amd_iommu_init_dma_ops(void)
{ {
struct amd_iommu *iommu; struct amd_iommu *iommu;
...@@ -2253,8 +2264,6 @@ int __init amd_iommu_init_dma_ops(void) ...@@ -2253,8 +2264,6 @@ int __init amd_iommu_init_dma_ops(void)
/* Make the driver finally visible to the drivers */ /* Make the driver finally visible to the drivers */
dma_ops = &amd_iommu_dma_ops; dma_ops = &amd_iommu_dma_ops;
register_iommu(&amd_iommu_ops);
amd_iommu_stats_init(); amd_iommu_stats_init();
return 0; return 0;
......
...@@ -1292,9 +1292,12 @@ static int __init amd_iommu_init(void) ...@@ -1292,9 +1292,12 @@ static int __init amd_iommu_init(void)
ret = amd_iommu_init_passthrough(); ret = amd_iommu_init_passthrough();
else else
ret = amd_iommu_init_dma_ops(); ret = amd_iommu_init_dma_ops();
if (ret) if (ret)
goto free; goto free;
amd_iommu_init_api();
amd_iommu_init_notifier(); amd_iommu_init_notifier();
enable_iommus(); enable_iommus();
......
...@@ -203,6 +203,15 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = { ...@@ -203,6 +203,15 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
DMI_MATCH(DMI_BOARD_NAME, "0T656F"), DMI_MATCH(DMI_BOARD_NAME, "0T656F"),
}, },
}, },
{ /* Handle problems with rebooting on Dell OptiPlex 760 with 0G919G*/
.callback = set_bios_reboot,
.ident = "Dell OptiPlex 760",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 760"),
DMI_MATCH(DMI_BOARD_NAME, "0G919G"),
},
},
{ /* Handle problems with rebooting on Dell 2400's */ { /* Handle problems with rebooting on Dell 2400's */
.callback = set_bios_reboot, .callback = set_bios_reboot,
.ident = "Dell PowerEdge 2400", .ident = "Dell PowerEdge 2400",
......
...@@ -642,19 +642,27 @@ static struct dmi_system_id __initdata bad_bios_dmi_table[] = { ...@@ -642,19 +642,27 @@ static struct dmi_system_id __initdata bad_bios_dmi_table[] = {
DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix/MSC"), DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix/MSC"),
}, },
}, },
{
/* /*
* AMI BIOS with low memory corruption was found on Intel DG45ID board. * AMI BIOS with low memory corruption was found on Intel DG45ID and
* It hase different DMI_BIOS_VENDOR = "Intel Corp.", for now we will * DG45FC boards.
* It has a different DMI_BIOS_VENDOR = "Intel Corp.", for now we will
* match only DMI_BOARD_NAME and see if there is more bad products * match only DMI_BOARD_NAME and see if there is more bad products
* with this vendor. * with this vendor.
*/ */
{
.callback = dmi_low_memory_corruption, .callback = dmi_low_memory_corruption,
.ident = "AMI BIOS", .ident = "AMI BIOS",
.matches = { .matches = {
DMI_MATCH(DMI_BOARD_NAME, "DG45ID"), DMI_MATCH(DMI_BOARD_NAME, "DG45ID"),
}, },
}, },
{
.callback = dmi_low_memory_corruption,
.ident = "AMI BIOS",
.matches = {
DMI_MATCH(DMI_BOARD_NAME, "DG45FC"),
},
},
#endif #endif
{} {}
}; };
......
...@@ -282,10 +282,21 @@ static int uv_rtc_unset_timer(int cpu, int force) ...@@ -282,10 +282,21 @@ static int uv_rtc_unset_timer(int cpu, int force)
/* /*
* Read the RTC. * Read the RTC.
*
* Starting with HUB rev 2.0, the UV RTC register is replicated across all
* cachelines of it's own page. This allows faster simultaneous reads
* from a given socket.
*/ */
static cycle_t uv_read_rtc(struct clocksource *cs) static cycle_t uv_read_rtc(struct clocksource *cs)
{ {
return (cycle_t)uv_read_local_mmr(UVH_RTC); unsigned long offset;
if (uv_get_min_hub_revision_id() == 1)
offset = 0;
else
offset = (uv_blade_processor_id() * L1_CACHE_BYTES) % PAGE_SIZE;
return (cycle_t)uv_read_local_mmr(UVH_RTC | offset);
} }
/* /*
......
...@@ -222,7 +222,7 @@ static void nmi_cpu_switch(void *dummy) ...@@ -222,7 +222,7 @@ static void nmi_cpu_switch(void *dummy)
/* move to next set */ /* move to next set */
si += model->num_counters; si += model->num_counters;
if ((si > model->num_virt_counters) || (counter_config[si].count == 0)) if ((si >= model->num_virt_counters) || (counter_config[si].count == 0))
per_cpu(switch_index, cpu) = 0; per_cpu(switch_index, cpu) = 0;
else else
per_cpu(switch_index, cpu) = si; per_cpu(switch_index, cpu) = si;
...@@ -598,6 +598,7 @@ static int __init ppro_init(char **cpu_type) ...@@ -598,6 +598,7 @@ static int __init ppro_init(char **cpu_type)
case 15: case 23: case 15: case 23:
*cpu_type = "i386/core_2"; *cpu_type = "i386/core_2";
break; break;
case 0x2e:
case 26: case 26:
spec = &op_arch_perfmon_spec; spec = &op_arch_perfmon_spec;
*cpu_type = "i386/core_i7"; *cpu_type = "i386/core_i7";
......
...@@ -729,9 +729,6 @@ int __init agp_amd64_init(void) ...@@ -729,9 +729,6 @@ int __init agp_amd64_init(void)
if (agp_off) if (agp_off)
return -EINVAL; return -EINVAL;
if (gart_iommu_aperture)
return agp_bridges_found ? 0 : -ENODEV;
err = pci_register_driver(&agp_amd64_pci_driver); err = pci_register_driver(&agp_amd64_pci_driver);
if (err < 0) if (err < 0)
return err; return err;
...@@ -768,6 +765,14 @@ int __init agp_amd64_init(void) ...@@ -768,6 +765,14 @@ int __init agp_amd64_init(void)
return err; return err;
} }
static int __init agp_amd64_mod_init(void)
{
if (gart_iommu_aperture)
return agp_bridges_found ? 0 : -ENODEV;
return agp_amd64_init();
}
static void __exit agp_amd64_cleanup(void) static void __exit agp_amd64_cleanup(void)
{ {
if (gart_iommu_aperture) if (gart_iommu_aperture)
...@@ -777,7 +782,7 @@ static void __exit agp_amd64_cleanup(void) ...@@ -777,7 +782,7 @@ static void __exit agp_amd64_cleanup(void)
pci_unregister_driver(&agp_amd64_pci_driver); pci_unregister_driver(&agp_amd64_pci_driver);
} }
module_init(agp_amd64_init); module_init(agp_amd64_mod_init);
module_exit(agp_amd64_cleanup); module_exit(agp_amd64_cleanup);
MODULE_AUTHOR("Dave Jones <davej@redhat.com>, Andi Kleen"); MODULE_AUTHOR("Dave Jones <davej@redhat.com>, Andi Kleen");
......
...@@ -89,13 +89,17 @@ static long uv_mmtimer_ioctl(struct file *file, unsigned int cmd, ...@@ -89,13 +89,17 @@ static long uv_mmtimer_ioctl(struct file *file, unsigned int cmd,
switch (cmd) { switch (cmd) {
case MMTIMER_GETOFFSET: /* offset of the counter */ case MMTIMER_GETOFFSET: /* offset of the counter */
/* /*
* UV RTC register is on its own page * Starting with HUB rev 2.0, the UV RTC register is
* replicated across all cachelines of it's own page.
* This allows faster simultaneous reads from a given socket.
*
* The offset returned is in 64 bit units.
*/ */
if (PAGE_SIZE <= (1 << 16)) if (uv_get_min_hub_revision_id() == 1)
ret = ((UV_LOCAL_MMR_BASE | UVH_RTC) & (PAGE_SIZE-1)) ret = 0;
/ 8;
else else
ret = -ENOSYS; ret = ((uv_blade_processor_id() * L1_CACHE_BYTES) %
PAGE_SIZE) / 8;
break; break;
case MMTIMER_GETRES: /* resolution of the clock in 10^-15 s */ case MMTIMER_GETRES: /* resolution of the clock in 10^-15 s */
...@@ -115,8 +119,8 @@ static long uv_mmtimer_ioctl(struct file *file, unsigned int cmd, ...@@ -115,8 +119,8 @@ static long uv_mmtimer_ioctl(struct file *file, unsigned int cmd,
ret = hweight64(UVH_RTC_REAL_TIME_CLOCK_MASK); ret = hweight64(UVH_RTC_REAL_TIME_CLOCK_MASK);
break; break;
case MMTIMER_MMAPAVAIL: /* can we mmap the clock into userspace? */ case MMTIMER_MMAPAVAIL:
ret = (PAGE_SIZE <= (1 << 16)) ? 1 : 0; ret = 1;
break; break;
case MMTIMER_GETCOUNTER: case MMTIMER_GETCOUNTER:
......
...@@ -587,7 +587,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf, ...@@ -587,7 +587,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf,
return count; return count;
} }
const struct file_operations filter_fops = { static const struct file_operations filter_fops = {
.read = filter_read, .read = filter_read,
.write = filter_write, .write = filter_write,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment