Commit 4d8672d1 authored by Gregory CLEMENT's avatar Gregory CLEMENT Committed by Mark Brown

spi: atmel: Remove and fix erroneous comments

Since CSAAT functionality support has been added. Some comments become
wrong. Fix them to match the current driver behavior.
Signed-off-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
Link: https://lore.kernel.org/r/20191017141846.7523-2-gregory.clement@bootlin.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent ae8fbf1d
...@@ -312,11 +312,9 @@ static bool atmel_spi_is_v2(struct atmel_spi *as) ...@@ -312,11 +312,9 @@ static bool atmel_spi_is_v2(struct atmel_spi *as)
* transmitted") Not so! Workaround uses nCSx pins as GPIOs; or newer * transmitted") Not so! Workaround uses nCSx pins as GPIOs; or newer
* controllers have CSAAT and friends. * controllers have CSAAT and friends.
* *
* Since the CSAAT functionality is a bit weird on newer controllers as * Even controller newer than ar91rm9200, using GPIOs can make sens as
* well, we use GPIO to control nCSx pins on all controllers, updating * it lets us support active-high chipselects despite the controller's
* MR.PCS to avoid confusing the controller. Using GPIOs also lets us * belief that only active-low devices/systems exists.
* support active-high chipselects despite the controller's belief that
* only active-low devices/systems exists.
* *
* However, at91rm9200 has a second erratum whereby nCS0 doesn't work * However, at91rm9200 has a second erratum whereby nCS0 doesn't work
* right when driven with GPIO. ("Mode Fault does not allow more than one * right when driven with GPIO. ("Mode Fault does not allow more than one
...@@ -1193,8 +1191,6 @@ static int atmel_spi_setup(struct spi_device *spi) ...@@ -1193,8 +1191,6 @@ static int atmel_spi_setup(struct spi_device *spi)
if (!as->use_cs_gpios) if (!as->use_cs_gpios)
csr |= SPI_BIT(CSAAT); csr |= SPI_BIT(CSAAT);
/* DLYBS is mostly irrelevant since we manage chipselect using GPIOs.
*/
csr |= SPI_BF(DLYBS, 0); csr |= SPI_BF(DLYBS, 0);
word_delay_csr = atmel_word_delay_csr(spi, as); word_delay_csr = atmel_word_delay_csr(spi, as);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment