Commit 4dfce407 authored by Krzysztof Hałasa's avatar Krzysztof Hałasa

WAN: cosmetic changes to generic HDLC

Signed-off-by: default avatarKrzysztof Hałasa <khc@pm.waw.pl>
parent d6f8aa85
...@@ -22,20 +22,19 @@ ...@@ -22,20 +22,19 @@
* - proto->start() and stop() are called with spin_lock_irq held. * - proto->start() and stop() are called with spin_lock_irq held.
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/inetdevice.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/skbuff.h> #include <linux/kernel.h>
#include <linux/module.h>
#include <linux/notifier.h>
#include <linux/pkt_sched.h> #include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/poll.h>
#include <linux/lapb.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/notifier.h> #include <linux/skbuff.h>
#include <linux/hdlc.h> #include <linux/slab.h>
#include <net/net_namespace.h> #include <net/net_namespace.h>
...@@ -109,7 +108,7 @@ static int hdlc_device_event(struct notifier_block *this, unsigned long event, ...@@ -109,7 +108,7 @@ static int hdlc_device_event(struct notifier_block *this, unsigned long event,
if (dev->get_stats != hdlc_get_stats) if (dev->get_stats != hdlc_get_stats)
return NOTIFY_DONE; /* not an HDLC device */ return NOTIFY_DONE; /* not an HDLC device */
if (event != NETDEV_CHANGE) if (event != NETDEV_CHANGE)
return NOTIFY_DONE; /* Only interrested in carrier changes */ return NOTIFY_DONE; /* Only interrested in carrier changes */
...@@ -357,7 +356,7 @@ static struct packet_type hdlc_packet_type = { ...@@ -357,7 +356,7 @@ static struct packet_type hdlc_packet_type = {
static struct notifier_block hdlc_notifier = { static struct notifier_block hdlc_notifier = {
.notifier_call = hdlc_device_event, .notifier_call = hdlc_device_event,
}; };
...@@ -367,8 +366,8 @@ static int __init hdlc_module_init(void) ...@@ -367,8 +366,8 @@ static int __init hdlc_module_init(void)
printk(KERN_INFO "%s\n", version); printk(KERN_INFO "%s\n", version);
if ((result = register_netdevice_notifier(&hdlc_notifier)) != 0) if ((result = register_netdevice_notifier(&hdlc_notifier)) != 0)
return result; return result;
dev_add_pack(&hdlc_packet_type); dev_add_pack(&hdlc_packet_type);
return 0; return 0;
} }
......
...@@ -9,19 +9,18 @@ ...@@ -9,19 +9,18 @@
* as published by the Free Software Foundation. * as published by the Free Software Foundation.
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/inetdevice.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/skbuff.h> #include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pkt_sched.h> #include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/poll.h>
#include <linux/lapb.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/hdlc.h> #include <linux/skbuff.h>
#include <linux/slab.h>
#undef DEBUG_HARD_HEADER #undef DEBUG_HARD_HEADER
...@@ -68,9 +67,9 @@ struct cisco_state { ...@@ -68,9 +67,9 @@ struct cisco_state {
static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr); static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr);
static inline struct cisco_state * state(hdlc_device *hdlc) static inline struct cisco_state* state(hdlc_device *hdlc)
{ {
return(struct cisco_state *)(hdlc->state); return (struct cisco_state *)hdlc->state;
} }
...@@ -172,7 +171,7 @@ static int cisco_rx(struct sk_buff *skb) ...@@ -172,7 +171,7 @@ static int cisco_rx(struct sk_buff *skb)
data->address != CISCO_UNICAST) data->address != CISCO_UNICAST)
goto rx_error; goto rx_error;
switch(ntohs(data->protocol)) { switch (ntohs(data->protocol)) {
case CISCO_SYS_INFO: case CISCO_SYS_INFO:
/* Packet is not needed, drop it. */ /* Packet is not needed, drop it. */
dev_kfree_skb_any(skb); dev_kfree_skb_any(skb);
...@@ -336,7 +335,7 @@ static struct hdlc_proto proto = { ...@@ -336,7 +335,7 @@ static struct hdlc_proto proto = {
static const struct header_ops cisco_header_ops = { static const struct header_ops cisco_header_ops = {
.create = cisco_hard_header, .create = cisco_hard_header,
}; };
static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr) static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr)
{ {
cisco_proto __user *cisco_s = ifr->ifr_settings.ifs_ifsu.cisco; cisco_proto __user *cisco_s = ifr->ifr_settings.ifs_ifsu.cisco;
...@@ -359,10 +358,10 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr) ...@@ -359,10 +358,10 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr)
return 0; return 0;
case IF_PROTO_CISCO: case IF_PROTO_CISCO:
if(!capable(CAP_NET_ADMIN)) if (!capable(CAP_NET_ADMIN))
return -EPERM; return -EPERM;
if(dev->flags & IFF_UP) if (dev->flags & IFF_UP)
return -EBUSY; return -EBUSY;
if (copy_from_user(&new_settings, cisco_s, size)) if (copy_from_user(&new_settings, cisco_s, size))
...@@ -372,7 +371,7 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr) ...@@ -372,7 +371,7 @@ static int cisco_ioctl(struct net_device *dev, struct ifreq *ifr)
new_settings.timeout < 2) new_settings.timeout < 2)
return -EINVAL; return -EINVAL;
result=hdlc->attach(dev, ENCODING_NRZ,PARITY_CRC16_PR1_CCITT); result = hdlc->attach(dev, ENCODING_NRZ,PARITY_CRC16_PR1_CCITT);
if (result) if (result)
return result; return result;
......
...@@ -33,20 +33,19 @@ ...@@ -33,20 +33,19 @@
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/etherdevice.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/inetdevice.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/skbuff.h> #include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pkt_sched.h> #include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/poll.h>
#include <linux/lapb.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/etherdevice.h> #include <linux/skbuff.h>
#include <linux/hdlc.h> #include <linux/slab.h>
#undef DEBUG_PKT #undef DEBUG_PKT
#undef DEBUG_ECN #undef DEBUG_ECN
...@@ -96,7 +95,7 @@ typedef struct { ...@@ -96,7 +95,7 @@ typedef struct {
unsigned ea1: 1; unsigned ea1: 1;
unsigned cr: 1; unsigned cr: 1;
unsigned dlcih: 6; unsigned dlcih: 6;
unsigned ea2: 1; unsigned ea2: 1;
unsigned de: 1; unsigned de: 1;
unsigned becn: 1; unsigned becn: 1;
......
...@@ -9,19 +9,18 @@ ...@@ -9,19 +9,18 @@
* as published by the Free Software Foundation. * as published by the Free Software Foundation.
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/inetdevice.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/skbuff.h> #include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pkt_sched.h> #include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/poll.h>
#include <linux/lapb.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/hdlc.h> #include <linux/skbuff.h>
#include <linux/slab.h>
#include <net/syncppp.h> #include <net/syncppp.h>
struct ppp_state { struct ppp_state {
......
...@@ -9,19 +9,18 @@ ...@@ -9,19 +9,18 @@
* as published by the Free Software Foundation. * as published by the Free Software Foundation.
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/inetdevice.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/skbuff.h> #include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pkt_sched.h> #include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/poll.h>
#include <linux/lapb.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/hdlc.h> #include <linux/skbuff.h>
#include <linux/slab.h>
static int raw_ioctl(struct net_device *dev, struct ifreq *ifr); static int raw_ioctl(struct net_device *dev, struct ifreq *ifr);
......
...@@ -9,20 +9,19 @@ ...@@ -9,20 +9,19 @@
* as published by the Free Software Foundation. * as published by the Free Software Foundation.
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/etherdevice.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/inetdevice.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/skbuff.h> #include <linux/kernel.h>
#include <linux/module.h>
#include <linux/pkt_sched.h> #include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/poll.h>
#include <linux/lapb.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/etherdevice.h> #include <linux/skbuff.h>
#include <linux/hdlc.h> #include <linux/slab.h>
static int raw_eth_ioctl(struct net_device *dev, struct ifreq *ifr); static int raw_eth_ioctl(struct net_device *dev, struct ifreq *ifr);
......
...@@ -9,20 +9,19 @@ ...@@ -9,20 +9,19 @@
* as published by the Free Software Foundation. * as published by the Free Software Foundation.
*/ */
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/slab.h>
#include <linux/poll.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/hdlc.h>
#include <linux/if_arp.h> #include <linux/if_arp.h>
#include <linux/init.h>
#include <linux/skbuff.h>
#include <linux/pkt_sched.h>
#include <linux/inetdevice.h> #include <linux/inetdevice.h>
#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/lapb.h> #include <linux/lapb.h>
#include <linux/module.h>
#include <linux/pkt_sched.h>
#include <linux/poll.h>
#include <linux/rtnetlink.h> #include <linux/rtnetlink.h>
#include <linux/hdlc.h> #include <linux/skbuff.h>
#include <linux/slab.h>
#include <net/x25device.h> #include <net/x25device.h>
static int x25_ioctl(struct net_device *dev, struct ifreq *ifr); static int x25_ioctl(struct net_device *dev, struct ifreq *ifr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment