Commit 4fed1b12 authored by Jan Beulich's avatar Jan Beulich Committed by Boris Ostrovsky

xen/manage: correct return value check on xenbus_scanf()

A negative return value indicates an error; in fact the function at
present won't ever return zero.
Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent cc272163
...@@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch *watch, const char **vec, ...@@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_watch *watch, const char **vec,
err = xenbus_transaction_start(&xbt); err = xenbus_transaction_start(&xbt);
if (err) if (err)
return; return;
if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) { if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) {
pr_err("Unable to read sysrq code in control/sysrq\n"); pr_err("Unable to read sysrq code in control/sysrq\n");
xenbus_transaction_end(xbt, 1); xenbus_transaction_end(xbt, 1);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment